Skip to content

fix(recently-deleted): dim the list and disable Restore while a new view loads - #8966

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/recently-deleted-placeholder
Oct 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/recently-deleted-placeholder

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Recently Deleted keeps the previous page as placeholder data across tab, search, and sort changes (server pagination from improvement(perf): bound trash, file-path and attachment reads #8945), but the view never read isPlaceholderData, so the old rows showed under the new controls with live Restore buttons and no loading cue
  • Dim the list and disable Restore while the new view loads, matching the credit-usage view's isPlaceholderData treatment
  • Keeps the placeholder itself: dropping it would blank the list on every tab switch

Type of Change

  • Bug fix

Testing

  • biome check on the changed file; lint, audits, type-check, and tests run in CI
  • No unit test: the change is a rendered disabled/opacity state, which the testing rules exclude

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 13, 2026 5:58am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Recently Deleted keeps the previous rows visible while a new view loads.

  • Recently Deleted dims old rows and disables Restore while results update.

Reviews (1) · Last reviewed commit: "fix(recently-deleted): dim the list and ..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 03450b2 into staging Oct 13, 2026
39 of 40 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/recently-deleted-placeholder branch October 13, 2026 06:02

This branch was previously deployed

1 inactive deployment
Preview — f351a70b Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant