fix(knowledge): key vision checkpoints by title and keep excluded images off while disabled by waleedlatif1 · Pull Request #8965 · simstudioai/sim

waleedlatif1 · 2026-10-13T05:57:48Z

Summary

Vision checkpoints now include the filename in their cache key, since the extraction prompt names it as the title, so a rename never reuses text extracted under the old title
Restoring an excluded image is rejected while the connector's image attachments are off. Turning images off keeps excluded rows so the exclusion survives turning them back on, but those rows still hold their indexed text, and restoring one re-enabled text the source no longer lists
Follow-up to feat(knowledge): index Confluence image attachments #8949, from the release PR review

Type of Change

Bug fix

Testing

vision-checkpoints.test.ts: added a renamed-title case, which fails without the fix
confluence-images.integration.ts: an excluded image stays excluded with images off, restore is rejected, and restore succeeds after images come back on (runs in CI)
Targeted vitest on application/connectors, vision-checkpoints and image-extraction (67 passed); biome on touched files

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ges off while disabled

vercel · 2026-10-13T05:57:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 13, 2026 6:29am UTC

cubic-dev-ai

All reported issues were addressed across 5 files

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-13T06:03:23Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge, with both earlier restore issues addressed.

Summary

This PR prevents vision checkpoints from reusing text after a filename changes and rejects image restores while image attachments are off.

Renamed images get a fresh vision extraction checkpoint.
Excluded images stay off until image attachments are enabled.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Restore requested] --> B[Update selected documents in transaction]
  B --> C{Restored rows include images?}
  C -->|No| G[Commit]
  C -->|Yes| D[Read settings with shared connector lock]
  D --> E{Image attachments enabled?}
  E -->|Yes| G
  E -->|No| F[Reject and roll back]

_{Reviews (4) · Last reviewed commit: "improvement(knowledge): read the connect..." · Reviewed by Greptile}

…nsaction

waleedlatif1 · 2026-10-13T06:07:39Z

@greptile

waleedlatif1 · 2026-10-13T06:07:41Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-13T06:07:47Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-13T06:17:21Z

@greptile

waleedlatif1 · 2026-10-13T06:17:23Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-13T06:17:29Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 5 files

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-13T06:29:30Z

@greptile

waleedlatif1 · 2026-10-13T06:29:32Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-13T06:29:38Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic}

fix(knowledge): key vision checkpoints by title and keep excluded ima…

f273106

…ges off while disabled

waleedlatif1 mentioned this pull request Oct 13, 2026

v0.9.20: project membership enforcement, db and perf improvements, realtime and auth hardening, CI and test fixes #8963

Merged

cubic-dev-ai Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread apps/sim/lib/knowledge/application/connectors.ts Outdated

greptile-apps Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread apps/sim/lib/knowledge/application/connectors.ts Outdated

fix(knowledge): check the image setting and restore in one locked tra…

55d2840

…nsaction

vercel Bot temporarily deployed to Preview October 13, 2026 06:07 Inactive

cubic-dev-ai Bot reviewed Oct 13, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread apps/sim/lib/knowledge/application/connectors.ts Outdated

fix(knowledge): take the image restore locks in sync's order

851d265

vercel Bot temporarily deployed to Preview October 13, 2026 06:17 Inactive

cubic-dev-ai Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread apps/sim/lib/knowledge/application/connectors.ts

improvement(knowledge): read the connector image setting with toRecord

2201de6

vercel Bot temporarily deployed to Preview October 13, 2026 06:29 Inactive

cubic-dev-ai Bot reviewed Oct 13, 2026

View reviewed changes

waleedlatif1 merged commit 831d11d into staging Oct 13, 2026
51 checks passed

waleedlatif1 deleted the fix/kb-image-release-review branch October 13, 2026 15:33

waleedlatif1 mentioned this pull request Oct 13, 2026

fix(knowledge): bill Gemini spend for image reads that fail the pass #8967

Merged

6 tasks done

Conversation

waleedlatif1 commented Oct 13, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

waleedlatif1 commented Oct 13, 2026

Uh oh!

waleedlatif1 commented Oct 13, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 13, 2026

Uh oh!

waleedlatif1 commented Oct 13, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 13, 2026

Uh oh!

waleedlatif1 commented Oct 13, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Oct 13, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 13, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading