Skip to content

fix(recently-deleted): keep previous-criteria rows inert while the new list loads - #8964

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/recently-deleted-stale-actions
Oct 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/recently-deleted-stale-actions

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Recently Deleted keeps the previous tab/search/sort rows on screen while the new criteria load (no flicker), but they could still be restored and could drive infinite scroll
  • While those rows are placeholder data, disable Restore and stop the load-more sentinel, so a stale hasNextPage can't fetch a "next page" against the new criteria
  • Matches how other settings surfaces treat isPlaceholderData as not-yet-current data

Type of Change

  • Bug fix

Testing

  • biome on the changed file; type-check, lint, and audits in CI
  • No component test added: the change is a disabled/enabled condition the repo's testing rules ask not to restate

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 13, 2026 5:55am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; both guards block actions on placeholder rows and allow them again when current data arrives.

Summary

Keeps previous tab, search, and sort results visible while the new Recently Deleted list loads.

  • Recently Deleted waits for current rows before restore or load-more.

Reviews (1) · Last reviewed commit: "fix(recently-deleted): keep previous-cri..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 2b5dbf7 into staging Oct 13, 2026
39 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/recently-deleted-stale-actions branch October 13, 2026 05:59

This branch was previously deployed

1 inactive deployment
Preview — 5caadd65 Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant