Skip to content

fix(ci): remove Project image digest migration gate - #8961

Merged
mzxchandra merged 1 commit into
stagingfrom
codex/remove-project-rollout-gate
Oct 13, 2026
Merged

mzxchandra merged 1 commit into
stagingfrom
codex/remove-project-rollout-gate

Conversation

@mzxchandra

Copy link
Copy Markdown
Contributor

Summary

The Project-specific image-digest gate added by #8590 blocks every later staging deployment while the Project migration is pending, including unrelated PRs. Remove that gate and its manually populated GitHub variables from the shared migration workflow.

Delete the unused Python checker and its tests, and remove the migration job's AWS secret forwarding and OIDC permission. Retain the database prerequisite check, migration ordering, authority switch, transactional backfill, constraints, and completion-receipt validation unchanged. No replacement deployment-verification infrastructure is added.

Rollout

Keep this PR in draft until the one-time staging compatibility and relevant worker-drain check is complete. Merging it allows the pending migration to proceed through normal CI; removing the gate is not evidence that the rollout is safe. Production requires its own compatibility verification before this change is deployed there. Supported rollback remains #8830 or compatible newer code.

Testing

  • Local: actionlint 1.7.12 passed for both changed workflows; git diff --check passed.
  • Verified there are no remaining references to the removed checker or readiness variables in workflows/scripts.
  • Database code is unchanged; full validation runs in hosted PR CI.
  • No migration, deployment, or workflow rerun was performed for this PR.

@vercel

vercel Bot commented Oct 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Building Building Preview Oct 13, 2026 3:49am UTC

Request Review

@mzxchandra

Copy link
Copy Markdown
Contributor Author

@greptile

@mzxchandra

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Critical impact] No new blocking code issue was found; merge remains subject to the staging checks stated in the rollout plan.

Summary

Removes the Project image-digest gate from the shared migration workflow.

  • Project migrations proceed without an image-digest deployment gate.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[CI checks pass] --> B[Check database prerequisites]
  B -->|Pass| C[Run database migrations]
  B -->|Fail| D[Stop job]
  C --> E[Promote application image]
Loading

Reviews (2) · Last reviewed commit: "fix(ci): remove Project image digest mig..." · Reviewed by Greptile

@mzxchandra
mzxchandra marked this pull request as ready for review October 13, 2026 03:55
@mzxchandra
mzxchandra merged commit 4af0f26 into staging Oct 13, 2026
39 of 40 checks passed
@mzxchandra
mzxchandra deleted the codex/remove-project-rollout-gate branch October 13, 2026 03:56

This branch was successfully deployed

1 active deployment
Preview — f7a8e44c Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant