Skip to content

fix(ui): simplify responsive layouts and compact workflow controls - #8960

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/simplify-responsive-layouts
Oct 13, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/simplify-responsive-layouts

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Use the phone layout below 768px and the regular layout at and above it for workflow panels and chat resources, with matching CSS and JavaScript boundaries.
  • Keep workflow action faces compact on phones while preserving 44px touch targets and full-width Chip behavior through the shared design-system helper.
  • Align canvas, floating-panel, and resource-resize bounds with the rendered layout, including fractional widths at 768px.

Type of Change

  • Bug fix

Testing

  • Cleanup review; lint; all 26 workspace type checks; all 59 audits, including docs and generated artifacts; block-registry check.
  • 175 focused tests and root bun run test (script tests plus all 20 workspace test tasks).
  • 191 real-browser checks passed across Chromium/WebKit at 320–1920px, with an additional 768px resize boundary exercised in both browsers. JSON reports, screenshots, and traces retained locally.
  • Regression checks fail when either fractional measurement or consistent accessibility rounding is removed; both pass with the fix.
  • Compact full-width Chip/ChipLink behavior failed before the fix in Chromium and WebKit; all 10 browser fixture cases pass afterward.
  • The Electron chat-panel scenario passes all 16 checks. Its mid-drag resize case now stays in the regular layout and still verifies clamping and preference restoration.
  • The updated boundary suite passes 29 checks across Chromium and WebKit.
  • Resize accessibility assertions use one browser snapshot and await the existing layout synchronization; both negative controls still fail when the underlying geometry fixes are removed.
  • Existing CI runs the mobile suite against the production build in separate Chromium and WebKit jobs, plus the Electron E2E suite.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 13, 2026 4:25am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 25 files

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

Comment thread packages/emcn/src/components/chip/chip.tsx Outdated
@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issue remains.

Summary

The PR aligns phone layouts below 768px, keeps workflow controls compact, and measures rendered panel widths.

  • Workflow panels and chat resources use phone layouts below 768px.
  • Workflow buttons keep small faces and roomy touch targets on phones.
  • Panel resizing and floating windows follow the panel's visible width.

Reviews (3) · Last reviewed commit: "fix(test): sample responsive resize geom..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 27 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 27 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 824b5d3 into staging Oct 13, 2026
53 of 54 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/simplify-responsive-layouts branch October 13, 2026 05:50
TheodoreSpeaks added a commit that referenced this pull request Oct 13, 2026
Staging #8960 replaced the chat panel's container queries with max-md breakpoints and
useIsMobile. The panel overlay, both header controls and the sliding content keep working on
that layout: the resize hook now always records --chat-panel-width (saved width, or half the
layout) instead of relying on a 50cqw fallback. Recently Deleted takes staging's paginated
query and keeps includeChats, onViewResource and the settings workspace id.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lrd1NLD9qx2KBLVnw32c3E

This branch was previously deployed

1 inactive deployment
Preview — da8263b3 Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant