Skip to content

chore(ci): fail closed on missing test Redis in CI and skip the unused pg16 service - #8938

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/ci-test-hygiene
Oct 12, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/ci-test-hygiene

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Redis-gated suites can't pass by skipping in CI. readTestRedisUrl() returns undefined when TEST_REDIS_URL is unset, and about 29 Redis-gated integration tests then skip. It now throws when CI is set and the var is missing; locally it still skips. The integration job sets TEST_REDIS_URL for all 8 matrix jobs (checks.yml:68), and no other workflow runs integration tests, so CI stays green.
  • The pg16 service starts only where it's used. The postgres:16-alpine service container started on all 8 integration jobs, but only push/1 uses it: port 5433 appears only in its step. The other 7 jobs now get an empty image, which GitHub skips.
  • Smoke tests that never ran are now live tests. csv-workflow-execution (SIM_HELPERS_SMOKE) and providers/conversation-smoke are whole-file smoke suites gated on env vars no workflow sets. They are renamed to *.live.test.ts, the repo's opt-in layer, and their 20 test-patterns baseline entries are removed.

Not changed: apps/desktop/playwright.config.ts retries once in CI. Logs from 143 recent runs show 8 green desktop runs that passed only on that retry. Switching to failOnFlakyTests before fixing those tests would turn about 6% of runs red. That's a follow-up.

Test plan

  • All 8 integration jobs green; push/1 still passes its PostgreSQL 16 step
  • check:audits (check:test-patterns)

…16 service

- readTestRedisUrl throws when CI is set and TEST_REDIS_URL is missing, so
  Redis-gated integration suites can no longer pass by skipping
- start the postgres:16 service only on integration (push, 1/4), the one job
  whose step uses it
- move the two env-gated smoke files that no workflow enables to *.live.test.ts
  and shrink the test-patterns baseline accordingly
@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 12, 2026 7:57pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge; no actionable issue was found.

Summary

The PR makes CI integration runs fail when TEST_REDIS_URL is missing, while keeping Redis optional locally.

  • CI requires a Redis URL before integration suites can run.
  • PostgreSQL 16 starts only for the integration job that tests it.
  • Two gated smoke suites run only in live-test mode.

No actionable issues found. This review checked code and configuration; it did not run the suites.

Acknowledged deferral: waleedlatif1 explicitly left desktop retry behavior unchanged. The stated reason is that enabling failOnFlakyTests before fixing flaky tests would turn about 6% of recent runs red.

Reviews (1) · Last reviewed commit: "chore(ci): fail closed on missing test R..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit c55698a into staging Oct 12, 2026
38 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/ci-test-hygiene branch October 12, 2026 20:11

This branch was successfully deployed

1 active deployment
Preview — dcda64b0 Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant