Skip to content

fix(e2e): connect the mobile suite to realtime and give dev-server round trips the server budget - #8937

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/mobile-e2e-flakes
Oct 12, 2026
Merged

fix(e2e): connect the mobile suite to realtime and give dev-server round trips the server budget#8937
waleedlatif1 merged 2 commits into
stagingfrom
fix/mobile-e2e-flakes

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

e2e (mobile) failed the first attempt on 6 of the last 43 staging pushes, and both attempts of the v0.9.19 release run on main. A different single check failed each time (185 of 186 passed). This PR fixes the three causes found in recent CI history.

  • Unlock Workflow tap timeout (webkit/phone; 4 failures, including the release run's attempt 2). CI never started the realtime server, so about 2s after any workspace page loads a "Reconnecting..." toast appears and stays. On the locked-workflow reload it races the lock toast. When it lands second it sits on top and intercepts the tap on Unlock Workflow; the failure trace shows "subtree intercepts pointer events". The mobile group now starts the realtime server on :3025 (stopped on exit, the same pattern desktop-live uses), so the toast never appears.
  • Sidebar navigation URL / Files list / table cell after reload (chromium/small-phone and webkit/phone). next dev took 16.4s to serve the /home RSC payload; 70ms of that was application code, and the rest was the dev server reloading modules. These checks waited 20s; the suite gives every other dev-server round trip 120s, and they now get 120s too.
  • Speedup: the browsers now install while the app boots (about 50s saved).

"The long draft must have a scrollable editor" was already fixed by #8892: 19 failures before it, 0 in 94 runs since.

Not fixed here:

  • Two WebKit "Page crashed" failures, none since 10-10; no browser output was captured.
  • One ResizeObserver-loop error.

Test plan

  • CI e2e (mobile) passes, and its log shows "mobile realtime server ready"

@waleedlatif1
fix(e2e): connect the mobile suite to realtime and give dev-server ro…
c941ef0 
…und trips the server budget

- Start the realtime server for the mobile group. Without it every workspace page raised a
  persistent "Reconnecting..." toast ~2s after load; on the locked-workflow reload it raced the
  lock toast and, when it arrived second, sat in front of the Unlock Workflow action, so the tap
  timed out on "subtree intercepts pointer events"
- Wait 120s, the suite's budget for a next dev round trip, for the URL after a sidebar link tap,
  the Files list after it, and the table cell after a reload. next dev spent 16.4s (application
  code 70ms) serving the /home RSC payload and left the rows request unanswered past 20s
- Install the browsers while the app boots
@vercel

vercel Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 12, 2026 8:07pm UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 12, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium impact] Adds realtime server startup to end-to-end test infrastructure.

The PR appears safe to merge, with a non-blocking cleanup gap for the background browser installer.

Findings

  1. P2 Installer outlives failed startup ▶

Summary

The mobile suite now starts a realtime server and gives selected navigation, file-list, and table-reload checks 120 seconds.

  • Mobile E2E pages connect to a local realtime server.
  • Browser installation runs while the app starts.
  • Mobile E2E checks wait longer for slow page loads.

waleedlatif1 explicitly deferred WebKit crashes and ResizeObserver errors in the PR description.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Mobile suite] --> B[Install browsers in background]
  A --> C[Start app and wait for health]
  C --> D[Start realtime and wait for health]
  D --> E[Wait for browser installation]
  B --> E
  E --> F[Run mobile checks]
  F --> G[Stop app and realtime]
Loading

Reviews (3) · Last reviewed commit: "fix(e2e): connect the mobile suite to re..." · Reviewed by Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Oct 12, 2026
View reviewed changes
Comment thread .github/scripts/http-e2e.sh Outdated
@waleedlatif1

waleedlatif1 commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 12, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 140f1ae into staging Oct 12, 2026
48 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/mobile-e2e-flakes branch October 12, 2026 20:49
greptile-apps[bot]
greptile-apps Bot reviewed Oct 12, 2026
View reviewed changes
Comment thread .github/scripts/http-e2e.sh Outdated
Comment on lines +188 to +189
bunx --no-install playwright install --with-deps chromium webkit &
browsers_pid=$!

@greptile-apps greptile-apps Bot Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Installer outlives failed startup

The browser installer now runs in the background, but finish() only stops the app and realtime server. If either server fails during startup, wait_ready() exits before wait "$browsers_pid", leaving downloads or package installs running through later CI steps. Track and stop the installer’s children in the exit cleanup too.

@TheodoreSpeaks TheodoreSpeaks mentioned this pull request Oct 13, 2026
Merged

This branch was successfully deployed

1 active deployment
Preview — f0a501ce Deployed Oct 12, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1