Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
markdownlint-cli2andmarkdownlint-cli2-formatter-templatewith pinnedrumdl@0.2.78.pnpm markdown-lintandpnpm markdown-lint-fix, usingrumdl check .andrumdl check --fix .respectively..rumdl.toml, with comments explaining all 47 enabled rules and the six previously disabled rules. Additional rumdl rules are not enabled as part of this migration.markdownlint-disablecomments, and markdownlint defaults for code-block tabs, blockquoted lists, and case-sensitive fragments.pnpm markdown-lint --output-format githubfor built-in GitHub Actions annotations instead of the formatter dependency..cache/rumdl, already covered by.gitignore, and update the local-development documentation.Local before/after benchmarks
Measured on the same 338 Markdown files during the migration's read-only comparison. Both tools returned zero issues, and their enumerated file sets were identical.
Environment: Apple M4 Pro, macOS 27.0.1, arm64, Node.js 24.21.0, pnpm 11.28.4.
node_modules/.bin/markdownlint-cli2node_modules/.bin/rumdl check --no-cache .node_modules/.bin/rumdl check .Methodology: run each command once as an untimed warm-up, then measure five sequential subprocess runs with Python's
time.perf_counter()and report the median. Output was captured and every run exited successfully. Timings include CLI launcher/process startup, but exclude installation and pnpm command startup. The filesystem cache was not cleared: "result cache disabled" is not a cold-filesystem benchmark. These are local measurements, not a claim about CI performance.Raw measured wall times in seconds:
0.879222, 0.870512, 0.942448, 0.956442, 0.958149.0.248351, 0.225197, 0.225420, 0.277993, 0.215380.0.198974, 0.205987, 0.224327, 0.389236, 0.635433.Validation
pnpm exec rumdl check --no-cache --deny-config-warnings .: passes on all 338 files.pnpm markdown-lint,pnpm markdown-lint --output-format github, andpnpm markdown-lint-fix: pass; the fixer makes no additional Markdown changes.pnpm check --allfor the changed files: passes. The local runner required putting the working Corepack pnpm shim first onPATHto avoid an unrelatedENOEXECfrom another local pnpm shim.git diff --check: passes. No new unit tests were added and the full repository unit-test suite was not run.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
OpenCode using GPT-6.1 Sol (
github-copilot/gpt-6.1-sol) authored the configuration, dependency/script/CI changes, documentation, configuration smoke checks, local benchmark comparison, and this PR description under the contributor's direction.Use of AI in replying to PR comments
Who answers review comments:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: http://github.com/setchy/renovate/tree/feat/markdown-rumdl
A reproduction is compulsory for PRs that do not close an Issue: link a public repository above that reproduces the bug or shows the new behavior.
If this PR closes an Issue, confirm the fix against the Issue's reproduction.
If you are not adding a reproduction, state your reason here:
PRs without a reproduction or a stated reason will not be reviewed and may be closed.