Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124320010. |
Summary: Several "for frameworks" headers included fine-grained headers of public modules directly. A framework author includes a for-frameworks header directly, outside any umbrella, so under `RN_STRICT_API` those includes hit the public module's `UmbrellaGuard.h` `#error`, which `RN_ALLOW_FRAMEWORKS` does not suppress. Switch them to the module umbrellas: - Image component (`ImageComponentDescriptor.h`, `ImageEventEmitter.h`, `ImageProps.h`, `ImageShadowNode.h`, `ImageState.h`): `<React/View.h>`, `<React/RendererCore.h>`, `<React/Graphics.h>`, `<React/ImageManager.h>`. - `ComponentDescriptorFactory.h`: `<React/RendererCore.h>`, `<React/Utils.h>`, `<React/ComponentRegistry.h>`. - `react/renderer/core` `DynamicEventPayload.h`, `DynamicPointerEvent.h`, `DynamicPropsUtilities.h`, `ReactRootViewTagGenerator.h`: `<React/RendererCore.h>`. - `DefaultTurboModules.h`: `<React/NativeModuleCore.h>`. - iOS/macOS `RCTInstance.h` and `RCTContextContainerHandling.h`: `<React/CallInvoker.h>`, `<React/Utils.h>`. Includes of for-frameworks headers in the same module stay direct, since umbrellas do not re-export them. The `react/renderer/core` headers and `ComponentDescriptorFactory.h` now include their own module's umbrella, so the CMake `react_renderer_core` and `react_renderer_componentregistry` targets expose their umbrella directory as `PUBLIC` instead of `INTERFACE`: core's own sources (`EventEmitter.cpp`, `Props.cpp`, `ShadowNode.cpp`, ...) include these headers and must resolve `<React/RendererCore.h>` too. Each umbrella is a superset of the headers it replaces, so no declarations are lost. The guards are inert without `RN_STRICT_API`. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D124320010
coado
force-pushed
the
export-D124320010
branch
from
October 12, 2026 13:48
85142c5 to
8a7faea
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Several "for frameworks" headers included fine-grained headers of public modules directly. A framework author includes a for-frameworks header directly, outside any umbrella, so under
RN_STRICT_APIthose includes hit the public module'sUmbrellaGuard.h#error, whichRN_ALLOW_FRAMEWORKSdoes not suppress. Switch them to the module umbrellas:ImageComponentDescriptor.h,ImageEventEmitter.h,ImageProps.h,ImageShadowNode.h,ImageState.h):<React/View.h>,<React/RendererCore.h>,<React/Graphics.h>,<React/ImageManager.h>.ComponentDescriptorFactory.h:<React/RendererCore.h>,<React/Utils.h>,<React/ComponentRegistry.h>.react/renderer/coreDynamicEventPayload.h,DynamicPointerEvent.h,DynamicPropsUtilities.h,ReactRootViewTagGenerator.h:<React/RendererCore.h>.DefaultTurboModules.h:<React/NativeModuleCore.h>.RCTInstance.handRCTContextContainerHandling.h:<React/CallInvoker.h>,<React/Utils.h>.Includes of for-frameworks headers in the same module stay direct, since umbrellas do not re-export them. The
react/renderer/coreheaders andComponentDescriptorFactory.hnow include their own module's umbrella, so the CMakereact_renderer_coreandreact_renderer_componentregistrytargets expose their umbrella directory asPUBLICinstead ofINTERFACE: core's own sources (EventEmitter.cpp,Props.cpp,ShadowNode.cpp, ...) include these headers and must resolve<React/RendererCore.h>too. Each umbrella is a superset of the headers it replaces, so no declarations are lost. The guards are inert withoutRN_STRICT_API.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D124320010