Repository navigation
Conversation
drakeo338
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
October 13, 2026 11:13
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-159303.
With no custom handler set,
call_exception_handler()calleddefault_exception_handler()in the caller's context. gh-96704 made a custom handler run in the task's or handle's context, and its PR left the default handler for later. This moves the lookup into a helper and uses it for both.Both handlers run in
ctx.copy(). Without the copy, reporting from inside the task itself ('task': asyncio.current_task()) raisesRuntimeError: cannot enter context, and a custom handler is silently skipped today.Three tests in
test_base_events:The docs note both changes. The issue's repro now prints
req-1twice../python -m test --fast-ci -j8 test_asynciopasses.Prepared with AI assistance (Claude), then reviewed and tested before submission.