Repository navigation
gh-159266: Don't reify lazy imports when completing global names in the REPL - #159267
Open
brittanyrey wants to merge 1 commit into
Open
brittanyrey wants to merge 1 commit into
brittanyrey wants to merge 1 commit into
Conversation
fancycompleter's global_matches() eval()ed every matching name to pick its color, which imported lazily imported modules on <Tab>. Look the value up in the namespace and builtins instead, as rlcompleter does.
brittanyrey
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
October 12, 2026 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tab completing within the REPL was triggering a reify of any lazily imported module whose name matched the completer. Instead, we can look up the value directly in the namespace & finally in the builtins.
With this change you will not get colors for a lazily imported module/object until it is reified.