Repository navigation
gh-159229: Fix IDNA incremental encoder error offsets - #159233
Closed
wjc2821296948 wants to merge 5 commits into
Closed
wjc2821296948 wants to merge 5 commits into
wjc2821296948 wants to merge 5 commits into
Conversation
Co-Authored-By: chaogeshuodiannao <chaogeshuodiannao@users.noreply.github.com>
Co-Authored-By: chaogeshuodiannao <chaogeshuodiannao@users.noreply.github.com>
|
All commit authors signed the Contributor License Agreement. |
Co-Authored-By: chaogeshuodiannao <chaogeshuodiannao@users.noreply.github.com>
Co-Authored-By: chaogeshuodiannao <chaogeshuodiannao@users.noreply.github.com>
Co-Authored-By: chaogeshuodiannao <chaogeshuodiannao@users.noreply.github.com>
Author
|
Closing this because I missed that the issue reporter had already said they wanted to work on the fix. Sorry for the overlap. I'll leave this issue to the reporter so they can submit their implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IDNA incremental encoder tracks the consumed offset using the Unicode label length, even though it appends the IDNA-encoded bytes. For non-ASCII labels this makes a later UnicodeEncodeError report offsets that are too small.
Track the actual encoded byte length instead, and add a regression test covering a non-ASCII label followed by an invalid overlong label.
AI assistance was used to inspect the existing code and draft this focused change. The patch was reviewed against the issue reproducer and existing codec behavior before submission.
Closes #159229