Repository navigation
Fix thread unloading after disconnect during MCP startup - #50380
Merged
copyberry[bot] merged 1 commit intoOct 2, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why If required MCP startup outlasts the requesting connection's cleanup, the newly created thread can remain loaded without subscribers because its listener is never started. ## What changed Start the thread listener even when the requesting connection has already closed, allowing normal idle unloading to clean up the thread while preserving the `ConnectionClosed` result. ## Testing Add a regression test that disconnects during blocked required MCP startup, then releases startup and verifies a `thread/closed` notification, an empty `thread/loaded/list`, and MCP process exit on Unix. GitOrigin-RevId: 4ad912a82177266316042d806f5faa1713a48fa4
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/4ad912a82177266316042d806f5faa1713a48fa4
branch
from
October 2, 2026 17:40
b588f6d to
1ab8c6e
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/4ad912a82177266316042d806f5faa1713a48fa4
branch
October 2, 2026 17:40
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix thread unloading after disconnect during MCP startup
Why
If required MCP startup outlasts the requesting connection's cleanup, the newly created thread can remain loaded without subscribers because its listener is never started.
What changed
Start the thread listener even when the requesting connection has already closed, allowing normal idle unloading to clean up the thread while preserving the
ConnectionClosedresult.Testing
Add a regression test that disconnects during blocked required MCP startup, then releases startup and verifies a
thread/closednotification, an emptythread/loaded/list, and MCP process exit on Unix.