Skip to content

Protect the guardian decisions API key from environment forwarding - #50019

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1adeef814fdccb2d6c77dd68f7a5dfcec0b41cc6
Oct 1, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1adeef814fdccb2d6c77dd68f7a5dfcec0b41cc6

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Protect the guardian decisions API key from environment forwarding

What changed

Add CODEX_GUARDIAN_DECISIONS_API_KEY to the non-inheritable environment variables and the HTTP header environment denylist. Case-insensitive filtering removes it from child process environments, including explicit shell policy and command overrides, and rejects its use through http/request header value_env_var.

Testing

Extend regression coverage for inherited and overridden variables, mixed-case names, and HTTP header rejection before any network request is sent.

…50019)

## What changed

Add `CODEX_GUARDIAN_DECISIONS_API_KEY` to the non-inheritable environment variables and the HTTP header environment denylist. Case-insensitive filtering removes it from child process environments, including explicit shell policy and command overrides, and rejects its use through `http/request` header `value_env_var`.

## Testing

Extend regression coverage for inherited and overridden variables, mixed-case names, and HTTP header rejection before any network request is sent.

GitOrigin-RevId: 1adeef814fdccb2d6c77dd68f7a5dfcec0b41cc6
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/1adeef814fdccb2d6c77dd68f7a5dfcec0b41cc6 branch from f845867 to 9552906 Compare October 1, 2026 15:58
@copyberry
copyberry Bot merged commit 9552906 into main Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/1adeef814fdccb2d6c77dd68f7a5dfcec0b41cc6 branch October 1, 2026 15:58
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2026
@aroeshink
aroeshink deployed to issue-triage October 1, 2026 16:04 — with GitHub Actions Active
@aroeshink
aroeshink deployed to issue-triage October 1, 2026 16:04 — with GitHub Actions Active
@aroeshink
aroeshink deployed to issue-triage October 1, 2026 16:04 — with GitHub Actions Active
@aroeshink
aroeshink deployed to issue-triage October 1, 2026 16:05 — with GitHub Actions Active
@Dakhaasje
Dakhaasje deployed to issue-triage October 1, 2026 16:05 — with GitHub Actions Active
@Dakhaasje
Dakhaasje deployed to issue-triage October 1, 2026 16:05 — with GitHub Actions Active
@Dakhaasje
Dakhaasje deployed to issue-triage October 1, 2026 16:05 — with GitHub Actions Active
@Dakhaasje
Dakhaasje deployed to issue-triage October 1, 2026 16:06 — with GitHub Actions Active
@wbdb
wbdb deployed to issue-triage October 1, 2026 16:09 — with GitHub Actions Active
@wbdb
wbdb deployed to issue-triage October 1, 2026 16:09 — with GitHub Actions Active
@wbdb
wbdb deployed to issue-triage October 1, 2026 16:09 — with GitHub Actions Active
@wbdb
wbdb deployed to issue-triage October 1, 2026 16:10 — with GitHub Actions Active
@LibrariusDei
LibrariusDei deployed to issue-triage October 1, 2026 16:12 — with GitHub Actions Active
@LibrariusDei
LibrariusDei deployed to issue-triage October 1, 2026 16:12 — with GitHub Actions Active
@LibrariusDei
LibrariusDei deployed to issue-triage October 1, 2026 16:12 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 9552906b Deployed Oct 1, 2026 by LibrariusDei via Identify potential duplicates (all issues) #50600
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants