Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
2afab9a
build: do not include shared gtest in `node` link path
aduh95 Oct 11, 2026
1a33e91
deps: V8: cherry-pick 7d5eb1df2a72
inoway46 Oct 7, 2026
d4c87eb
test: scope Blob WPT failures to big-endian
panva Sep 26, 2026
7d4fda6
test: honor allowed WPT promise rejections
panva Sep 26, 2026
c348a4c
test: run instantiateStreaming-bad-imports WPT
panva Sep 26, 2026
6fbffd5
meta: bump codecov/codecov-action from 7.1.0 to 7.1.1
dependabot[bot] Oct 3, 2026
4760c27
tools: bump the eslint group in /tools/eslint with 5 updates
dependabot[bot] Oct 3, 2026
9618da6
test: remove duplicated cases in permission fs-read fixture
RafaelGSS Oct 3, 2026
b2773d5
doc: add missing return types in cluster.md
Cayan Oct 4, 2026
c1073f3
ffi: fix exportArrayBuffer type check
trivikr Oct 4, 2026
20441b8
test: run node-bench tools test sequentially
panva Oct 4, 2026
c6f0614
crypto: remove select Web Crypto warnings
panva Oct 4, 2026
4ba6ce1
stream: port remaining SonicBoom tests for Utf8Stream
mcollina Oct 5, 2026
63c20ee
vfs: add ComposableProvider for layered mounts
mcollina Oct 5, 2026
cd86506
src: mark config file as stable
marco-ippolito Oct 1, 2026
2e3dd5b
src: fix config file handling
marco-ippolito Oct 1, 2026
b18e121
test_runner: add mock call assertions to t.assert
araujogui Oct 6, 2026
7f1937d
http: add websocketMask() and websocketUnmask()
jasnell Sep 27, 2026
ab05798
watch: strip underscore aliases of watch flags
trivikr Oct 6, 2026
5b87354
quic: destroy stream on invalid promise body
christianaurichzm Oct 6, 2026
c3204c1
quic: validate session close error codes
christianaurichzm Oct 6, 2026
c442f47
module: synchronously load most ES modules
GeoffreyBooth Oct 6, 2026
1e8247a
doc: run license-builder
github-actions[bot] Oct 7, 2026
54867cd
sqlite: throw on oversized strings instead of aborting
trivikr Oct 7, 2026
8904178
doc: document linux-x64-musl build toolchain
theSnackOverflow Oct 7, 2026
bbf41f8
sqlite: persist enableDefensive() across reopen
trivikr Oct 7, 2026
dbc3e97
tools: copy hdr_histogram_internal.h in update-histogram.sh
fcostaoliveira Oct 7, 2026
8d8af80
crypto: keep the root cert store per Environment
codebytere Sep 26, 2026
d6f566b
quic: give each BindingData its own allocator state
codebytere Sep 26, 2026
fa9fca4
tools: lint thread_local in src
codebytere Sep 26, 2026
c6f59d4
doc: clarify node binary misuse after compromise
RafaelGSS Oct 7, 2026
d6293e7
crypto: skip secret key mutex allocation
panva Sep 30, 2026
9d98805
crypto: remove RSA-OAEP key locking
panva Sep 30, 2026
883250f
crypto: remove KEM key locking
panva Sep 30, 2026
bcd8018
crypto: remove verify setup key locking
panva Sep 30, 2026
4e00a29
crypto: remove key export and metadata locks
panva Sep 30, 2026
f771134
crypto: isolate provider EC PKCS8 encoding
panva Oct 1, 2026
82223ab
doc: clarify revert PR label policy
aduh95 Oct 7, 2026
06f56a5
src: use native CopyArrayBufferBytes for webstream buffer copy
Renegade334 Oct 7, 2026
2cab299
lib: default node:bench warmup to 10 invocations
RafaelGSS Oct 5, 2026
05d0b14
lib: set exit code on failed node:bench run()
RafaelGSS Oct 5, 2026
93596b1
stream: add dump()/dumpSync() for stream/iter
Ethan-Arrowood Sep 4, 2026
30814ce
test: replace discard loops with dump()
Ethan-Arrowood Sep 4, 2026
da908b3
test_runner: report load errors with --test-isolation=none
lazerg Oct 8, 2026
062ece7
lib: fix benchmark record acknowledgement race
panva Oct 8, 2026
bb81658
doc: fix request.reusedSocket timeout example
efekrskl Sep 25, 2026
73a4e90
doc: document keepAliveTimeoutBuffer server option
efekrskl Sep 25, 2026
fc3b067
doc: clarify http Agent keepSocketAlive behavior
efekrskl Oct 8, 2026
5fd03e6
child_process: propagate config-file permission flags to children
RafaelGSS Oct 8, 2026
8462363
doc: document URL and Uint8Array references in process.permission
RafaelGSS Oct 8, 2026
4ce8412
benchmark: fix url-searchparams-sort to sort a fresh list
RafaelGSS Oct 5, 2026
9ef698c
sqlite: validate aggregate() name and options
araujogui Oct 9, 2026
714aca1
tools: switch to PGP and SHA256 in ICU updater
aduh95 Oct 9, 2026
cd8b5fa
test: tolerate async block count updates in test-fs-stat-bigint
RafaelGSS Oct 10, 2026
1722ced
lib: add --allow-fs-vfs to permission available flags
RafaelGSS Oct 10, 2026
1ebd6d3
doc,lib,src: throw on missing WebAssembly or RX support
ShogunPanda Oct 10, 2026
1aa10d8
process: mark process.finalization as release candidate
mcollina Oct 1, 2026
e6662cb
stream: fix Utf8Stream flush handling
jasnell Oct 3, 2026
2f498f0
benchmark: add util.parseArgs benchmark
RafaelGSS Oct 10, 2026
115731d
http2: speed up response getHeaders
rozzilla Oct 10, 2026
adef722
benchmark: fix buffer option in buffer read/write benchmarks
RafaelGSS Oct 10, 2026
7309ddf
test_runner: rerun failing todo tests in suites
barakor Oct 10, 2026
30e76bb
benchmark: fix input passed to subtle.digest in webcrypto-digest
RafaelGSS Oct 10, 2026
700c60a
fs: serialize FileHandle writer() async writes
jasnell Oct 3, 2026
69148ee
fs: lock FileHandle on first read in pull() and pullSync()
jasnell Oct 3, 2026
fa49de9
stream: keep share buffer when all consumers detach
jasnell Oct 3, 2026
42ae085
stream: detach shareSync consumers on strict budget errors
jasnell Oct 3, 2026
30cbc4e
stream: reject drop-newest backpressure in shareSync()
jasnell Oct 3, 2026
8a47365
stream: split oversized share batches under drop-oldest
jasnell Oct 3, 2026
6b1e7c4
stream: guard shareSync() against re-entrant source reads
jasnell Oct 3, 2026
69d44ae
stream: bound pre-batched async values in from()
jasnell Oct 3, 2026
6eaf913
stream: do not hold back nested async data in from()
jasnell Oct 3, 2026
995dee6
stream: honor stream/iter protocols on function objects
jasnell Oct 3, 2026
dcac51a
stream: align pull() abort handling with the spec
jasnell Oct 3, 2026
7ba60dc
stream: keep the original error when writer.fail() throws
jasnell Oct 3, 2026
f302fbd
stream: reduce per-chunk overhead in stream/iter consumers
jasnell Oct 3, 2026
4b83c6c
stream: accept explicit stream/iter budgets below 16384
jasnell Oct 3, 2026
af41622
stream: reject closed fromWritable() writes with a TypeError
jasnell Oct 3, 2026
9648a6b
quic: reject closed stream writer writes with a TypeError
jasnell Oct 3, 2026
1683353
stream: fix fromSync() async input error messages
jasnell Oct 3, 2026
0e1c99a
doc: document stream/iter behaviors and Node.js extensions
jasnell Oct 3, 2026
6cecf14
stream: do not fail the writer when pipeToSync() cannot close
jasnell Oct 4, 2026
3f75c89
stream: add pipeToSync() failOnIncompleteClose option
jasnell Oct 4, 2026
f44aec4
deps: update simdjson to 5.0.3
lemire Oct 9, 2026
0e58916
src: stop including simdjson.h from env.h
lemire Oct 6, 2026
3294d51
diagnostics_channel: fix default callback context
mcollina Oct 11, 2026
493bd6c
benchmark,tools: fix napi benchmarks on GHA
nigrosimone Oct 11, 2026
007872a
deps: V8: cherry-pick 8d14d49c4040
aduh95 Oct 11, 2026
a888e51
build: support Python 3.15
MikeMcC399 Oct 11, 2026
bd567f8
module: fix require of imports with package map
lazerg Oct 11, 2026
447c36c
lib: fix AbortSignal.any() nested composite leak
DariusHQ Oct 12, 2026
83f5078
meta: bump nodejs/node-pr-labeler to dfe5eb3
soulee-dev Oct 12, 2026
e451555
build: run QUIC CI for V8 changes
inoway46 Oct 12, 2026
eaeb473
doc: add Test Runner to list of built-in diagnostic channels
vassudanagunta Oct 12, 2026
32833de
http: reduce raw header name allocations
rozzilla Oct 12, 2026
af946ba
deps: update sqlite to 3.54.0
nodejs-github-bot Oct 12, 2026
7eb230a
deps: update acorn to 8.19.0
nodejs-github-bot Oct 12, 2026
7ad17f5
2026-10-14, Version 26.12.0 (Current)
nodejs-github-bot Oct 12, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobs:
--arg withPerfetto ${{ matrix.perfetto || false }} \
--arg ccache '(import <nixpkgs> {}).sccache' \
--run '
make build-ci -j4 V=1
make build-ci -j4 V=1 ${{ contains(format(' {0} ', inputs.category), ' napi ') && '&& make bench-addons-build' || '' }}
' tools/nix/ci-shell.nix
env:
SCCACHE_LOCAL_RW_MODE: READ_ONLY
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
FLAKY_TESTS: keep_retrying
CLANG_VERSION: '19'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-linux-without-intl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
FLAKY_TESTS: keep_retrying
CLANG_VERSION: '19'
CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang-19
Expand Down Expand Up @@ -85,6 +85,6 @@ jobs:
- name: Clean tmp
run: rm -rf coverage/tmp && rm -rf out
- name: Upload
uses: codecov/codecov-action@0b35c9ecc4f0529d0eb674914510c22f85b196b4 # v7.1.0
uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1
with:
directory: ./coverage
4 changes: 2 additions & 2 deletions .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
FLAKY_TESTS: keep_retrying
CLANG_VERSION: '19'
CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang-19
Expand Down Expand Up @@ -85,6 +85,6 @@ jobs:
- name: Clean tmp
run: rm -rf coverage/tmp && rm -rf out
- name: Upload
uses: codecov/codecov-action@0b35c9ecc4f0529d0eb674914510c22f85b196b4 # v7.1.0
uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1
with:
directory: ./coverage
4 changes: 2 additions & 2 deletions .github/workflows/coverage-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
FLAKY_TESTS: keep_retrying
RUSTC_VERSION: '1.86'

Expand Down Expand Up @@ -101,6 +101,6 @@ jobs:
- name: Clean tmp
run: npx rimraf ./coverage/tmp
- name: Upload
uses: codecov/codecov-action@0b35c9ecc4f0529d0eb674914510c22f85b196b4 # v7.1.0
uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1
with:
directory: ./coverage
2 changes: 1 addition & 1 deletion .github/workflows/daily-wpt-fyi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
- cron: 30 0 * * *

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/label-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-slim

steps:
- uses: nodejs/node-pr-labeler@d4cf1b8b9f23189c37917000e5e17e796c770a6b # v1
- uses: nodejs/node-pr-labeler@dfe5eb3b099a487644e32567a482744620876ab3 # v1
with:
repo-token: ${{ secrets.GH_USER_TOKEN }}
configuration-path: .github/label-pr-config.yml
2 changes: 1 addition & 1 deletion .github/workflows/lint-release-proposal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
NODE_VERSION: lts/*

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
NODE_VERSION: lts/*

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stress-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ on:
type: string

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
XCODE_VERSION: '16.4'
CLANG_VERSION: '19'
RUSTC_VERSION: '1.86'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-internet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
FLAKY_TESTS: keep_retrying
CLANG_VERSION: '19'
CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang-19
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-linux-perfetto.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
FLAKY_TESTS: keep_retrying
CLANG_VERSION: '19'
CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang-19
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/test-linux-quic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
- configure.py
- node.gyp
- node.gypi
- deps/v8/**
- deps/ngtcp2/**
- deps/nghttp3/**
- deps/openssl/**
Expand All @@ -30,7 +31,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
FLAKY_TESTS: keep_retrying
CLANG_VERSION: '19'
CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang-19
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
FLAKY_TESTS: keep_retrying
CLANG_VERSION: '19'
CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang-19
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ concurrency:
cancel-in-progress: true

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'
XCODE_VERSION: '16.4'
FLAKY_TESTS: keep_retrying
RUSTC_VERSION: '1.86'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ on:
- zstd

env:
PYTHON_VERSION: '3.14'
PYTHON_VERSION: '3.15'

permissions:
contents: read
Expand Down
7 changes: 7 additions & 0 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ and libc version. The table below lists the support tier for each supported
combination. A list of [supported compile toolchains](#supported-toolchains) is
also supplied for tier 1 platforms.

Some built-in functionality requires WebAssembly or runtime allocation of
executable memory. When a capability is unavailable, Node.js does not guarantee
an alternative implementation of the affected feature. See the
[`--jitless` documentation](doc/api/cli.md#--jitless) and
[FFI documentation](doc/api/ffi.md) for the corresponding limitations and errors.

**For production applications, run Node.js on supported platforms only (Tier 1 or 2).**

Node.js does not support a platform version if a vendor has expired support
Expand Down Expand Up @@ -187,6 +193,7 @@ Binaries at <https://nodejs.org/download/release/> are produced on:
| linux-ppc64le | RHEL 8 with Clang 20.1 and gcc-toolset-14-libatomic-devel[^6] |
| linux-s390x | RHEL 8 with Clang 20.1 and gcc-toolset-14-libatomic-devel[^6] |
| linux-x64 | RHEL 8 with Clang 20.1 and gcc-toolset-14-libatomic-devel[^6] |
| linux-x64-musl | Alpine 3.23 with Clang 21 |
| win-arm64 | Windows Server 2022 (x64) with Visual Studio 2022 |
| win-x64 | Windows Server 2022 (x64) with Visual Studio 2022 |

Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V26.md#26.11.1">26.11.1</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V26.md#26.12.0">26.12.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V26.md#26.11.1">26.11.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V26.md#26.11.0">26.11.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V26.md#26.10.0">26.10.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V26.md#26.9.0">26.9.0</a><br/>
Expand Down
4 changes: 2 additions & 2 deletions LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -1184,8 +1184,8 @@ The externally maintained libraries used by Node.js are:
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2017 - 2025 R. Thomas
Copyright 2017 - 2025 Quarkslab
Copyright 2017 - 2026 R. Thomas
Copyright 2017 - 2026 Quarkslab

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
7 changes: 6 additions & 1 deletion SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,12 @@ then untrusted input must not lead to arbitrary JavaScript code execution.

* The developers and infrastructure that run it.
* The operating system that Node.js is running under and its configuration,
along with anything under the control of the operating system.
along with anything under the control of the operating system. An attacker
who can already run commands on the host and uses an official, signed
Node.js binary to execute malicious JavaScript does not exploit a
vulnerability in Node.js. A code signature identifies the publisher of the
Node.js binary; it is not a statement about the trustworthiness of the
scripts that binary executes.
* The deployment network environment for the privacy of traffic and routing
decisions, including internal networks through which Node.js traffic passes
and configured HTTP(S) proxy servers. Built-in proxy support is intended to
Expand Down
10 changes: 9 additions & 1 deletion android-configure
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Note that the mix of single and double quotes is intentional,
# as is the fact that the ] goes on a new line.
_=[ 'exec' '/bin/sh' '-c' '''
command -v python3.15 >/dev/null && exec python3.15 "$0" "$@"
command -v python3.14 >/dev/null && exec python3.14 "$0" "$@"
command -v python3.13 >/dev/null && exec python3.13 "$0" "$@"
command -v python3.12 >/dev/null && exec python3.12 "$0" "$@"
Expand All @@ -22,7 +23,14 @@ except ImportError:
from distutils.spawn import find_executable as which

print('Node.js android configure: Found Python {}.{}.{}...'.format(*sys.version_info))
acceptable_pythons = ((3, 14), (3, 13), (3, 12), (3, 11), (3, 10))
acceptable_pythons = (
(3, 15),
(3, 14),
(3, 13),
(3, 12),
(3, 11),
(3, 10),
)
if sys.version_info[:2] in acceptable_pythons:
import android_configure
else:
Expand Down
8 changes: 4 additions & 4 deletions benchmark/buffers/buffer-read-with-byteLength.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ const types = [
];

const bench = common.createBenchmark(main, {
buffer: ['fast'],
buffer: ['fast', 'slow'],
type: types,
n: [1e6],
byteLength: [1, 2, 3, 4, 5, 6],
byteLength: [1, 2, 4, 6],
});

function main({ n, buf, type, byteLength }) {
const buff = buf === 'fast' ?
function main({ n, buffer, type, byteLength }) {
const buff = buffer === 'fast' ?
Buffer.alloc(8) :
Buffer.allocUnsafeSlow(8);
const fn = `read${type}`;
Expand Down
6 changes: 3 additions & 3 deletions benchmark/buffers/buffer-read.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ const types = [
];

const bench = common.createBenchmark(main, {
buffer: ['fast'],
buffer: ['fast', 'slow'],
type: types,
n: [1e6],
});

function main({ n, buf, type }) {
const buff = buf === 'fast' ?
function main({ n, buffer, type }) {
const buff = buffer === 'fast' ?
Buffer.alloc(8) :
Buffer.allocUnsafeSlow(8);
const fn = `read${type}`;
Expand Down
6 changes: 3 additions & 3 deletions benchmark/buffers/buffer-write.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const types = [
];

const bench = common.createBenchmark(main, {
buffer: ['fast'],
buffer: ['fast', 'slow'],
type: types,
n: [1e6],
});
Expand Down Expand Up @@ -70,8 +70,8 @@ const byteLength = {
writeIntBE: 6,
};

function main({ n, buf, type }) {
const buff = buf === 'fast' ?
function main({ n, buffer, type }) {
const buff = buffer === 'fast' ?
Buffer.alloc(8) :
Buffer.allocUnsafeSlow(8);
const fn = `write${type}`;
Expand Down
6 changes: 5 additions & 1 deletion benchmark/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,11 @@ module.exports = {
return process.binding(bindingName);
}
},
buildType: process.features.debug ? 'Debug' : 'Release',
// As in test/common: a --debug-node build is still a Release build, and its
// addons are in build/Release.
buildType: process.config.target_defaults ?
process.config.target_defaults.default_configuration :
'Release',
createBenchmark(fn, configs, options) {
return new Benchmark(fn, configs, options);
},
Expand Down
2 changes: 0 additions & 2 deletions benchmark/crypto/webcrypto-digest.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ function measureLegacy(n, data, method) {
}

function measureSubtle(n, data, method) {
const ec = new TextEncoder();
data = ec.encode(data);
const jobs = new Array(n);
bench.start();
for (let i = 0; i < n; i++)
Expand Down
Loading
Loading