Skip to content

deps: update inspector_protocol to c0045057ce801744c5e88596a2f1bab1802e - #66653

Open
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-inspector_protocol
Open

nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-inspector_protocol

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of inspector_protocol to c0045057ce801744c5e88596a2f1bab1802e.

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. inspector Issues and PRs related to the V8 inspector protocol. labels Oct 11, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 11, 2026
@aduh95

aduh95 commented Oct 12, 2026

Copy link
Copy Markdown
Contributor
../../src/inspector_agent.cc:446:8: error: 'void node::inspector::{anonymous}::ChannelImpl::FallThrough(int, crdtp::span<unsigned char>, crdtp::span<unsigned char>)' marked 'override', but does not override
  446 |   void FallThrough(int call_id,
      |        ^~~~~~~~~~~
../../src/inspector_agent.cc: In member function 'void node::inspector::{anonymous}::ChannelImpl::dispatchProtocolMessage(const v8_inspector::StringView&)':
../../src/inspector_agent.cc:338:59: error: no matching function for call to 'crdtp::Dispatchable::Dispatchable(crdtp::span<unsigned char>)'
  338 |     Dispatchable dispatchable(crdtp::SpanFrom(cbor_buffer));
      |                                                           ^
../../src/inspector_agent.cc:338:59: note: there are 3 candidates
In file included from gen/src/node/inspector/protocol/Forward.h:15,
                 from gen/src/node/inspector/protocol/Protocol.h:18,
                 from gen/src/node/inspector/protocol/DOMStorage.h:10,
                 from ../../src/inspector/dom_storage_agent.h:7,
                 from ../../src/inspector_agent.cc:7:
../../deps/inspector_protocol/crdtp/dispatch.h:124:3: note: candidate 1: 'crdtp::Dispatchable::Dispatchable(crdtp::span<unsigned char>, std::string_view, crdtp::FallthroughCallback)'
  124 |   Dispatchable(span<uint8_t> serialized,
      |   ^~~~~~~~~~~~
../../deps/inspector_protocol/crdtp/dispatch.h:124:3: note: candidate expects 3 arguments, 1 provided
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: candidate 2: 'crdtp::Dispatchable::Dispatchable(const crdtp::Dispatchable&)'
  110 | class CRDTP_EXPORT Dispatchable {
      |                    ^~~~~~~~~~~~
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: no known conversion for argument 1 from 'crdtp::span<unsigned char>' {aka 'std::span<const unsigned char>'} to 'const crdtp::Dispatchable&'
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: candidate 3: 'crdtp::Dispatchable::Dispatchable(crdtp::Dispatchable&&)'
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: no known conversion for argument 1 from 'crdtp::span<unsigned char>' {aka 'std::span<const unsigned char>'} to 'crdtp::Dispatchable&&'
../../src/inspector_agent.cc:345:21: error: 'DispatchResult' is not a member of 'crdtp::UberDispatcher'
  345 |     UberDispatcher::DispatchResult result =
      |                     ^~~~~~~~~~~~~~
../../src/inspector_agent.cc:347:10: error: 'result' was not declared in this scope; did you mean 'ada::result'?
  347 |     if (!result.MethodFound()) {
      |          ^~~~~~
      |          ada::result
In file included from /nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/url_pattern.h:15,
                 from /nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/parser-inl.h:8,
                 from /nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada.h:40,
                 from ../../src/node_url.h:7,
                 from ../../src/inspector_agent.cc:29:
/nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/implementation.h:44:7: note: 'ada::result' declared here
   44 | using result = tl::expected<result_type, ada::errors>;
      |       ^~~~~~
../../src/inspector_agent.cc:352:5: error: 'result' was not declared in this scope; did you mean 'ada::result'?
  352 |     result.Run();
      |     ^~~~~~
      |     ada::result
/nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/implementation.h:44:7: note: 'ada::result' declared here
   44 | using result = tl::expected<result_type, ada::errors>;
      |       ^~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies PRs that add, update, or configure Node.js dependencies. inspector Issues and PRs related to the V8 inspector protocol. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants