Repository navigation
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
inoway46
marked this pull request as ready for review
October 7, 2026 10:18
Contributor
|
Shouldn't this land on Current first? |
Contributor
Author
|
Agreed, #66566 should land first. |
Backport the Maglev HeapNumber materialization fix to V8 13.6.
Emit a captured HeapNumber with its map and constant numeric value,
using the existing deoptimizer to allocate a fresh box. Reserve a
nonduplicatable object ID for each box. Keep the literal-number helper
for fixed double arrays and captured-object numeric values. No virtual
object slot traversal changes or prerequisite commits are needed.
This mirrors the existing V8 13.6 Turbolev map/value materialization.
Original commit message:
[maglev] Materialize a fresh HeapNumber per deoptimization
This matches what Turbolev graph builder already does to Maglev.
Fixed: 547819997
Change-Id: Iafc1185ef96db8816db36b295a3a4b7e528f9863
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8255554
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109347}
Refs: v8/v8@7d5eb1d
Refs: nodejs#66457
Refs: https://www.cve.org/CVERecord?id=CVE-2026-85045
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Assisted-by: Codex
inoway46
force-pushed
the
backport-v24-maglev-heapnumber
branch
from
October 11, 2026 08:50
1a48a0f to
4fa345f
Compare
aduh95
marked this pull request as draft
October 11, 2026 09:31
inoway46
marked this pull request as ready for review
October 12, 2026 15:54
Contributor
Author
|
The v26.x backport has landed in 1a33e91. I've marked this ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #66567 +/- ##
=================================================
+ Coverage 90.31% 92.50% +2.19%
=================================================
Files 711 371 -340
Lines 228425 165729 -62696
Branches 43160 25996 -17164
=================================================
- Hits 206293 153313 -52980
+ Misses 14090 12108 -1982
+ Partials 8042 308 -7734 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport v8/v8@7d5eb1d to fix returned objects sharing mutable double fields, as reported in #66457 (CVE-2026-85045).
The upstream regression fails on v24.21.0 and passes with this backport.
The v26.x backport landed in 1a33e91 (#66566).
Refs: #66457