Request a bot token for NCU

[aduh95]

The requested token should have the following permissions:

permissions:
  contents: write
  pull-requests: write

http://github.com/googleapis/release-please-action?tab=readme-ov-file#workflow-permissions

Fixes: #914

[targos]

fwiw I renamed this secret to RELEASE_PLEASE_GITHUB_TOKEN - iitm (in the bot's settings, not in the repo) to make it recognizable. I didn't know about this registry.

[aduh95]

It would be worth documenting what string to use on the bot's settings side (e.g. <name of the repo>: <Secret name>)

[nschonni]

yeah, there are others like http://github.com/nodejs/remark-preset-lint-node that probably need a similar token, but probably shouldn't be the same one I guess this is just the repo Secret Name, so maybe there isn't a collision

[joyeecheung]

By the way I think simply reusing the GITHUB_TOKEN can solve most permission issues? The permission of that token is defined directly in the workflow files, see https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#permissions so there won't be a need to request for a new token if it's used.

[aduh95]

@joyeecheung using the GITHUB_TOKEN would result in tests not being triggered without closing and reopening the PR, which is not ideal – hence this request.

[joyeecheung]

Oh I see it's specific to release-please http://github.com/googleapis/release-please-action?tab=readme-ov-file#github-credentials

[mcollina]

lgtm

[StefanXhunga]

Hello everyone, thank you for your support!