Repository navigation
feat(benchmark): report first nonempty transcript latency - #3734
Merged
Merged
Conversation
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
first_update_ms, which measures the first result message even when its transcript is empty.first_text_msfor the first non-blank partial or sentence text, including final-only transcripts, in each client JSONL row.clients_with_textalongside total clients and errors. Missing text remains null rather than becoming zero latency.Related to #3732. This makes first-result and first-visible-transcript measurements distinguishable; it does not resolve the reported high-concurrency tail latency.
Type of change
Validation
Tests first: 8 failed and 5 passed on the unchanged benchmark, including missing exported fields and failure to record the first text.
After implementation: 13 focused tests passed, including deterministic empty/whitespace/final-only/zero-latency/missing-text cases and a real localhost WebSocket round trip with two concurrent clients and synthetic PCM16 WAV input.
Test formatting, Python compilation, CLI
--help, andgit diff --checkpassed.Independent source review found no P1/P2 issue in the four-file scope.
python -m compileall funasr examples tests(targeted compilation passed for the changed client and test)Docs or links checked
Runtime/deployment command tested (no server/deployment change; benchmark CLI help and localhost round trip tested)
User impact
Realtime service operators can distinguish an early empty result from the first visible transcript and report how many clients actually received text when investigating latency.
Notes for reviewers
No server, decoder, model, dependency manifest, or existing metric semantics changed. No models were loaded and no GPU benchmark was run. Client-visible text is not model token-generation latency, a transcript-quality assertion, or a throughput claim.