Repository navigation
fix(frontend): use unique installed package keys - #667
Conversation
|
Small question: did you reproduce the issue locally? So we know that it is fixed for sure. |
|
Yes - I reproduced it locally with the same flow: two releases with the same name in different namespaces, then filter to cert-manager. Before the fix, the count dropped to 1 but the visible card still showed airbyte. With this change, the remaining card updates to cert-manager as expected. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 21.92% 28.38% +6.45%
==========================================
Files 14 15 +1
Lines 2239 2568 +329
==========================================
+ Hits 491 729 +238
- Misses 1701 1767 +66
- Partials 47 72 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Cool! Very clean |
Summary
Fixes #666
Claimed in #666 (comment)
Testing
lint-staged100.92.89.12:node node_modules/typescript/bin/tsc100.92.89.12:node node_modules/eslint/bin/eslint.js src/100.92.89.12:node node_modules/prettier/bin/prettier.cjs --check src/components/InstalledPackages/InstalledPackagesList.tsx src/components/InstalledPackages/InstalledPackagesList.cy.tsxcypress run --component --spec src/components/InstalledPackages/InstalledPackagesList.cy.tsx(Cypress binary version: not installedin the available environments)