Skip to content

fix(frontend): use unique installed package keys - #667

Merged
undera merged 1 commit into
komodorio:mainfrom
saudademjj:saudademjj/fix-installed-namespace-filter
Mar 19, 2026
Merged

undera merged 1 commit into
komodorio:mainfrom
saudademjj:saudademjj/fix-installed-namespace-filter

Conversation

@saudademjj

Copy link
Copy Markdown
Contributor

Summary

  • use a namespace/name composite key for installed package cards so React reconciliation does not reuse cards when releases share a name across namespaces
  • add a Cypress component regression test that reproduces filtering two releases with the same name in different namespaces

Fixes #666

Claimed in #666 (comment)

Testing

  • pre-commit lint-staged
  • remote on 100.92.89.12: node node_modules/typescript/bin/tsc
  • remote on 100.92.89.12: node node_modules/eslint/bin/eslint.js src/
  • remote on 100.92.89.12: node node_modules/prettier/bin/prettier.cjs --check src/components/InstalledPackages/InstalledPackagesList.tsx src/components/InstalledPackages/InstalledPackagesList.cy.tsx
  • not run: cypress run --component --spec src/components/InstalledPackages/InstalledPackagesList.cy.tsx (Cypress binary version: not installed in the available environments)

@undera

undera commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Small question: did you reproduce the issue locally? So we know that it is fixed for sure.

@saudademjj

saudademjj commented Mar 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Yes - I reproduced it locally with the same flow: two releases with the same name in different namespaces, then filter to cert-manager. Before the fix, the count dropped to 1 but the visible card still showed airbyte. With this change, the remaining card updates to cert-manager as expected.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.38%. Comparing base (4432071) to head (0d4db4f).
⚠️ Report is 7 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   21.92%   28.38%   +6.45%     
==========================================
  Files          14       15       +1     
  Lines        2239     2568     +329     
==========================================
+ Hits          491      729     +238     
- Misses       1701     1767      +66     
- Partials       47       72      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@undera

undera commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Cool! Very clean

@undera
undera merged commit f12f60f into komodorio:main Mar 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespaces filter in Installed page not works as expected

3 participants