Skip to content

Added ability to disable query to ArtifactHub via env - #515

Merged
undera merged 1 commit into
komodorio:mainfrom
alessandrodetta:feature/disable-artifact-query#506
Feb 23, 2024
Merged

undera merged 1 commit into
komodorio:mainfrom
alessandrodetta:feature/disable-artifact-query#506

Conversation

@alessandrodetta

@alessandrodetta alessandrodetta commented Feb 23, 2024 •

Copy link
Copy Markdown
Contributor

It is now possible to disable the query through environment variable HD_NO_ARTIFACT_HUB_QUERY.

Changes Proposed

As suggested by @undera in #506

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue: Closes trying to check artifacts on ArtifactHub #506
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

It is now possible to disable the query through environment variable HD_NO_ARTIFACT_HUB_QUERY
@codecov-commenter

codecov-commenter commented Feb 23, 2024 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.18%. Comparing base (b5bed10) to head (4b93040).
Report is 26 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage   30.18%   30.18%           
=======================================
  Files          10       10           
  Lines        1335     1335           
=======================================
  Hits          403      403           
  Misses        891      891           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undera

undera commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

Very good.
Unfortunately, we have no documentation place to reflect this flag

@undera
undera merged commit 274f1cd into komodorio:main Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trying to check artifacts on ArtifactHub

3 participants