Pre-release fixes for 1.2.1: valid block markup, review findings, WordPress 7.1

[jakemgold]

Follow-up to the 1.2.1 merge, from a fresh six-reviewer pass over 1.2.1 plus a WordPress 7.1 compatibility check. One commit per change (30) so any one can be dropped; every commit passes the suite on its own (checked in a throwaway worktree).

WordPress 7.1 and packaging

• Tested up to: 7.1. Core's AI Client SDK is byte-identical between 7.0.6 and 7.1.2, 7.1's connector changes are additive, and nothing the plugin calls is newly deprecated. Smoke-tested end to end in isolated WordPress Playground sandboxes on 7.1.2 / PHP 8.5 and 7.0.6 / PHP 8.2, with a mocked Anthropic API.
• Stop shipping bin/ and languages/.gitkeep (Plugin Check hidden_files error). The empty languages/ still ships.

Generated content (pre-existing since at least 1.2.0)

• Emit the block markup the editor saves. Nested lists, quotes, and code inside list items were cut in half, and code blocks and quotes were always "invalid content". Shapes with no 1:1 block are kept as one HTML block, exactly as written. Validated with real core block-library JavaScript from 7.0.6 and 7.1.2 on 63 fixtures (26 realistic AI shapes, the reviewer's adversarial set, and the simplification's edge cases): none of the realistic shapes has an invalid block or needs a deprecation repair. On 7.0.6, main fails 51 of the 63 fixtures, this branch 4, and those 4 fail identically on main.
• Neutralize AI-written text WordPress would read as markup.
  • A stray <: "PHP < 8.2 or WordPress >= 6.0" was saved as "PHP = 6.0".
  • Smuggled block comments: a wp:rss block rendered live.
  • Quoted shortcodes, which ran.

Regressions introduced by 1.2.1 (all low severity)

• Post-release tags (1.5.0-1, -p1, -patch.1) were never posted.
• Own-repo links were fetched without the token when their casing differed.
• Plural security keywords stopped classifying a release as security.
• Each run wiped unseen "drafts created" entries.
• Anonymous lookups scheduled retry runs and logged unconditionally.
• Transient GitHub failures were cached as "invalid token" for 15 minutes.
• The AI-failure notice never cleared.
• Enter-to-add fired on IME commits and key repeat.

Pre-existing issues, contained fixes (the batch Jake approved)

• Escape on a confirmation dialog left its confirm handler armed, so the next confirmation could also regenerate a published post the admin had declined. Verified in the browser: one confirm now triggers exactly one generation.
• Cut-off, refused, or bodiless AI responses are failures, never posts. Anthropic connector 1.0.3 returns token-limit text as a normal result, and 1.0.5 does the same for refusals. Verified end to end with 1.0.5.
• Code-fenced responses are unwrapped.
• Sites that never ran activation (network subsites, Composer installs) get their option rows on first boot. The first token save was being encrypted twice, and unchecked boxes could not be saved.
• Monitoring:
  • Releases left queued by an interrupted run are no longer posted for repositories paused or removed since.
  • A rate-limit stop is recorded in the run summary.
  • A renamed or transferred repository gets a clear error and is rejected when added.
• Manual "Generate draft" stays a draft even when a ghrp_post_status filter would publish it.
• Text corrections:
  • The AI disclosure names the plugin correctly.
  • The editor panel is translatable.
  • Help text and the readme's external-services disclosure (WordPress.org guideline 7) now match what the plugin actually sends.

Changelog updated under 1.2.1.

Deferred (need design decisions):

• rolling nightly/latest tags hiding versioned releases
• non-GitHub image hotlinks
• multisite token scoping and per-site deactivation cleanup
• pre-release-to-pre-release ordering
• Go-style module/vX tags
• deep research on Regenerate
• error-message UX for timeouts

Review round 1 (Codex), four blockers — all fixed:

• R1: discarding the whole queue lost a release when a newer one in the same stream shipped first. Queued entries are kept again (a69e199), and since e70dd36 only entries for a removed or paused repository are skipped.
• R2–R4: the converter reordered list text around nested lists, ran paragraph text together, and dropped <li value> numbering and heading ids. Heading ids are kept as anchors (f351d3a), and since bab7f3d any list or quote with no 1:1 block stays one HTML block, exactly as written, instead of being reshaped.
• Follow-ups also fixed:
  • unclosed elements no longer rescan the rest of the content (10,000 unclosed paragraphs: 4.8 s to 8 ms)
  • nothing is recursed into, so depth costs no more than length (20,000 nested quotes: 8 ms, 4 MiB)
  • only a normal finish becomes a post (2e01d40)
• The reviewer's probes were re-run unchanged after the simplification:
  • queue: matches main (both queued releases are generated)
  • content validation: four pre-existing residual cases remain, each failing identically on main. The fifth (a < inside a title attribute) no longer produces an invalid block, but KSES garbles its text exactly as on main.
  • provider, cron, and token probes: pass (untouched code)

Review round 2 (Codex delta recheck at e70dd36): R1–R3 closed, and both queue deviations and the native-or-HTML boundary accepted. R4 was only partly fixed: heading ids were matched with a word-character pattern anywhere in the opening tag, so c++, café, config[api], or an id written with a character reference was dropped, and id= text inside a title was taken as the id. Ids are now read with the DOM parser the converter already uses for image attributes and written back with core's serialize_block_attributes() and esc_attr() (2db1297). Codex's anchor probe passes on 7.0.6 and 7.1.2 after real KSES (main and the fix exit 0, e70dd36 exits 1); only those five fixtures' output changed, and each validates and round-trips byte-for-byte.

Simplification after round 1. Asked whether the round-1 fixes added unhelpful complexity, two did, and both are now reduced to the minimum that fixes the reported defect:

• Converter (bab7f3d): native blocks only for shapes that map 1:1 onto a core block as written: paragraphs, headings, flat lists of inline items (start/reversed kept), quotes made of paragraphs or bare text, code, tables, separators, images. Everything else (a nested list, block markup inside an item, <li value>, type, a <p> wrapped around block markup, a quote holding a list or a citation) is one HTML block, exactly as written. The list-item reshaping, all recursion, and the nesting cap are gone.
• Queue (e70dd36): entries are skipped only when their repository has been removed or paused. The pre-release and package re-checks, the de-duplication (a repeat entry already hits the cached AI response and the existing post), and the extra queue field are gone; Release_Queue is back to main's version.
• Net change: source −221/+74 lines, tests −87/+45.
• 7.1.2 validation note: in 7.1.2, core/html's save() returns null and its content is no longer sourced from the markup, so any validator that compares against save() flags every HTML block. Those blocks parse as valid, round-trip byte-for-byte, and need no deprecation; on 7.0.6 they validate cleanly.

Verification:

• composer test: 518 tests / 862 assertions / 1 pre-existing skip.
• Each new commit passes the full battery on its own, in a worktree with a copied vendor/.
• phpcs, phpstan, git diff --check, and lint:js all exit 0.
• Committed dist/ matches a fresh build.

🤖 Generated with Claude Code