Repository navigation
Hardening: add null guards and bounds checks to string, array, and table setters - #9385
Closed
anagnorisis2peripeteia wants to merge 1 commit into
Closed
anagnorisis2peripeteia wants to merge 1 commit into
anagnorisis2peripeteia wants to merge 1 commit into
Conversation
Author
|
Closing this pull request. These checks sit in accessors or helpers that run after verification. FlatBuffers checks an untrusted buffer in the verifier, once. A caller mistake is FLATBUFFERS_ASSERT. Returning 0, nullptr, false, or an empty value hides the mistake and changes behavior for a valid buffer. See the C++ guide section "Access of untrusted buffers" and the review on #8990. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include/flatbuffers/string.h,include/flatbuffers/array.h, andinclude/flatbuffers/table.h.include/flatbuffers/string.h:Data()is null inc_str().std::stringandstring_viewconstruction against null buffers and zero size.operator<against null string buffers.include/flatbuffers/array.h:Get()andGetMutablePointer()with out-of-bounds checks and null buffer guards.CopyFromSpan(): guard against null span and null destination data, and scale overlap check bysizeof(T).MutateImpl(): guard against out-of-bounds indices and null buffers.include/flatbuffers/table.h:SetPointer(): guard against null pointer arguments and validate that pointer offset is non-negative (val >= data_ + field_offset).tests/test.cppcovering all hardened paths.