Skip to content

fix(homebrew): use symbol format for macOS dependency in cask template - #1106

Merged
EtienneLescot merged 1 commit into
getopenscreen:mainfrom
easonwong-de:fix/cask-macos-syntax
Oct 12, 2026
Merged

EtienneLescot merged 1 commit into
getopenscreen:mainfrom
easonwong-de:fix/cask-macos-syntax

Conversation

@easonwong-de

@easonwong-de easonwong-de commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Use symbol format (:ventura) instead of deprecated string comparison (">= :ventura") for depends_on macos: in .github/workflows/update-homebrew-cask.yml.

In Homebrew, specifying depends_on macos: ">= :ventura" triggers the following deprecation warning:

Warning: Calling string comparison format for depends_on macos: is deprecated! Use depends_on macos: :ventura instead.

Specifying the symbol :ventura natively denotes macOS Ventura and newer without string comparison.

Related issue

Fixes getopenscreen/homebrew-openscreen#1

Type of change

  • Bug fix
  • Feature
  • Enhancement
  • Documentation
  • Refactor / maintenance
  • Performance
  • Security

Release impact

  • Patch
  • Minor
  • Major / breaking change
  • No release note needed

Desktop impact

  • Windows
  • macOS
  • Linux
  • Installer / packaging
  • Not platform-specific

Screenshots / video

N/A

Testing

Verified against Homebrew cask DSL specifications and deprecation rules.

Summary by CodeRabbit

  • Chores
    • Homebrew cask installation is now limited to macOS Ventura.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c51559d0-dd5d-4db8-90f9-dad81fd2f1dc

📥 Commits

Reviewing files that changed from the base of the PR and between 125ebd9 and 003c303.


📒 Files selected for processing (1)
  • .github/workflows/update-homebrew-cask.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

The cask generation workflow changes the macOS dependency from a minimum-version comparison to the :ventura symbol.

Changes

Homebrew cask dependency

Layer / File(s) Summary
Update macOS dependency declaration
.github/workflows/update-homebrew-cask.yml
The generated cask uses :ventura instead of the string comparison ">= :ventura".

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor · Severity of issue fixed: Low


Merge Risk: ⚪ Minimal · up to 003c3

The cask remains limited to Ventura and newer while using Homebrew’s documented dependency form. No merge-blocking risk was identified.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the Homebrew cask fix and the change from string comparison to symbol format.
Description check Passed The description includes all template sections, explains the deprecation fix, links the related issue, identifies the change type and impact, and reports testing.
Linked Issues check Passed Issue #1 requires replacing the deprecated string-comparison form in depends_on macos: with depends_on macos: :ventura. The whole-PR diff changes exactly that declaration in `.github/workflows/upd…
Out of Scope Changes check Passed The whole-PR diff contains one related change in .github/workflows/update-homebrew-cask.yml. It only updates the Homebrew cask macOS dependency declaration required by issue #1. No unrelated source,…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot EtienneLescot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Homebrew's own deprecation message asks for exactly this form.

@EtienneLescot
EtienneLescot merged commit 2a70bf7 into getopenscreen:main Oct 12, 2026
19 checks passed
@easonwong-de

Copy link
Copy Markdown
Contributor Author

Thanks for maintaining OpenScreen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling string comparison format for depends_on macos: is deprecated!

2 participants