Repository navigation
fix(auto): prepare auto request pool with resolved capabilities - #16419
Open
maxmad64bis wants to merge 1 commit into
Open
maxmad64bis wants to merge 1 commit into
maxmad64bis wants to merge 1 commit into
Conversation
maxmad64bis
force-pushed
the
fix/auto-request-prepared-capabilities
branch
from
October 12, 2026 12:15
5b4fdef to
c1f4909
Compare
maxmad64bis
marked this pull request as ready for review
October 12, 2026 12:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior change: the request pool now carries resolved capability values where it carried none before, so per-candidate weights can shift the way they already do on the combos route. An
auto/*request resolves model capabilities per candidate instead of reusing one prepared pool, so database reads grow with the candidate count. Each request arm reuses its own prepared pool with resolved capabilities, and the same targets keep getting served.Related Issues
Target Branch
release/v3.8.xbranch (the highest openrelease/v*), notmainv4-featurelabel for the v4 channelValidation
npm run lintTests Added Or Updated
tests/unit/combos-auto-request-prepared-capabilities.test.ts— 6 tests covering bounded reads on both request arms, per-candidate reads without the change, target parity as sets, vision-bridge parity, and the existing 503 on an empty pool.Coverage Notes
open-sse/services/autoCombo/virtualFactory.ts— covered by the wrapper bounded-reads test.src/sse/handlers/autoRouting.ts— covered by the wrapper bounded-reads test.src/sse/handlers/chatHelpers.ts— covered by the bounded-reads, parity, and empty-pool tests.Reviewer Notes
open-sse/services/autoCombo/virtualFactory.tsfrom 1258 to 1262.