Repository navigation
Conversation
The local-index stale region check falls back to the scan stop row when EXPECTED_UPPER_REGION_KEY is absent. Reversed scans are swapped on the client, so the stop row is the region start key and every region looks stale. Set the attribute to the region end key in setLocalIndexAttributes so the check is direction-independent. When the check passes, setupLocalIndexScan must also accept the swapped boundaries. It took the key prefix from the start row, which is the region end key for a reversed scan, so the scan returned no rows. Take the prefix from the region start key in both directions. For a reversed scan, put the stop row suffix in the start row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The older-client fallback still rejects client-swapped reversed scans as stale.
1 open finding
What changed in this PR
Adds direction-independent stale-region detection for local index scans.
Changes:
- Records the expected region end key on local index scans.
- Correctly rewrites reversed scan boundaries.
- Adds boundary, split, merge, and open-ended-region tests.
| File | Description |
|---|---|
ScanUtil.java |
Sets region-end metadata and handles reversed boundaries. |
BaseScannerRegionObserver.java |
Exposes boundary checking for tests and updates documentation. |
ScanUtilTest.java |
Tests local-index scan attributes. |
LocalIndexScanBoundaryTest.java |
Tests server-side boundary detection and rewriting. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local index stale region check falls back to the scan stop row when EXPECTED_UPPER_REGION_KEY is absent. Reversed scans are swapped on the client, so the stop row is the region start key and every region looks stale.
Set the attribute to the region end key in setLocalIndexAttributes so the check is direction independent. When the check passes, setupLocalIndexScan must also accept the swapped boundaries. Take the prefix from the region start key in both directions. For a reversed scan, put the stop row suffix in the start row.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com