Skip to content

[FLINK-40972][table] Do not generate cast classes in case of Identity casts - #29462

Open
snuyanzin wants to merge 1 commit into
apache:masterfrom
snuyanzin:flink40972
Open

snuyanzin wants to merge 1 commit into
apache:masterfrom
snuyanzin:flink40972

Conversation

@snuyanzin

@snuyanzin snuyanzin commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

What is the purpose of the change

The idea is to stop generation of dummy CastExecutor classes in case of identity casts
for instance in case of TPCDS query8 it generates 400 classes like that

Brief change log

CastRuleProvider

Verifying this change

test added

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Tool Name and Version]

@flinkbot

flinkbot commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@fhueske fhueske left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @snuyanzin!

+1 to merge once CI passes.

Cheers, Fabian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants