Repository navigation
Conversation
Related PR: apache#67636 Problem Summary: CloudReplica image deserialization created independent String cluster IDs and boxed Long backend IDs for equivalent routes. The tested production image contains 4,197,906 replicas and 62,708,955 routes but only 15 cluster IDs and about 85 backend IDs, so millions of equal route identifiers retained duplicate heap objects. Canonical sharing reduced forced-GC live heap from 15,311,045,744 bytes to 8,539,550,968 bytes, saving 6,771,494,776 bytes (6.31 GiB, 44.2%). Intern cluster IDs and primary backend IDs on route updates and after image deserialization so equal routes reuse the same objects. Use Guava weak interners instead of strong process-lifetime maps: active routes keep canonical objects alive, while identifiers become collectable after their last route is removed. Routing behavior and the serialized image format are unchanged. The full 6.93 GB image completed compatibility load and dump with the final weak-interner implementation. A clean run loaded in 225.679 seconds and dumped in 145.935 seconds. JFR attributed 255 of 18,139 load-stage CPU samples (1.41%) to the interner path, with no sampled allocations attributed directly to it. Reduce FE heap usage for CloudReplica routing metadata and release unused historical route identifiers. - Test: Unit Test / Manual test - CloudReplicaTest: 23 tests passed - ./build.sh --fe passed with Checkstyle 0 violations - Full production image compatibility load and dump passed - JFR profile verified the interner path is not a load hotspot (cherry picked from commit 818d3f6)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from #68783
Related PR: #67636
Problem Summary: CloudReplica image deserialization created independent String cluster IDs and boxed Long backend IDs for equivalent routes. The tested production image contains 4,197,906 replicas and 62,708,955 routes but only 15 cluster IDs and about 85 backend IDs, so millions of equal route identifiers retained duplicate heap objects. Canonical sharing reduced forced-GC live heap from 15,311,045,744 bytes to 8,539,550,968 bytes, saving 6,771,494,776 bytes (6.31 GiB, 44.2%).
Intern cluster IDs and primary backend IDs on route updates and after image deserialization so equal routes reuse the same objects. Use Guava weak interners instead of strong process-lifetime maps: active routes keep canonical objects alive, while identifiers become collectable after their last route is removed. Routing behavior and the serialized image format are unchanged.
The full 6.93 GB image completed compatibility load and dump with the final weak-interner implementation. A clean run loaded in 225.679 seconds and dumped in 145.935 seconds. JFR attributed 255 of 18,139 load-stage CPU samples (1.41%) to the interner path, with no sampled allocations attributed directly to it.
Reduce FE heap usage for CloudReplica routing metadata and release unused historical route identifiers.
(cherry picked from commit 818d3f6)
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)