Repository navigation
fix(@angular/cli): resolve package name in npm workspace members - #34308
Merged
alan-agius4 merged 2 commits intoOct 13, 2026
Merged
Conversation
alan-agius4
added
action: review
4 of 13 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes getCurrentPackageName by reading package.json directly before falling back to the package manager command, and adds support for handling workspace objects returned by package managers. Unit tests were added to verify these changes. Feedback suggests simplifying a test mock in package-manager_spec.ts to remove dead code, as the package manager command is no longer invoked during that test.
Read `package.json` in the working directory first in `getCurrentPackageName` to avoid spawning an unnecessary child process, and handle single-entry workspace objects returned by `npm pkg get name` when falling back to the package manager command. Closes angular#32787
alan-agius4
force-pushed
the
fix/npm-workspace-package-name
branch
from
October 12, 2026 11:26
2ee0a44 to
088f196
Compare
clydin
approved these changes
Oct 12, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read
package.jsonin the working directory first ingetCurrentPackageNameto avoid spawning an unnecessary child process, and handle single-entry workspace objects returned bynpm pkg get namewhen falling back to the package manager command.Closes #32787