Skip to content

fix(@angular/build): enhance build logs and output location for library builder - #34288

Merged
alan-agius4 merged 2 commits into
angular:mainfrom
alan-agius4:feat-lib-build-logs
Oct 13, 2026
Merged

alan-agius4 merged 2 commits into
angular:mainfrom
alan-agius4:feat-lib-build-logs

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Aligns library builder logs with the application builder format:

  • Log Library bundle generation complete. [X seconds] - <timestamp> on build completion (or failed if errors occurred)
  • Log Output location: <outputPath> on successful builds
  • Log Watch mode enabled. Watching for file changes... only when watch mode is active, after the initial build completes

@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: @angular/build labels Oct 8, 2026
@alan-agius4
alan-agius4 requested a review from clydin October 8, 2026 13:02
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Oct 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the logging output of the Angular library builder, including moving the watch mode log, adding the elapsed time and timestamp to the build completion message, and displaying the output path on success. It also adds a unit test to verify these logs. The feedback suggests logging build failures as errors rather than info messages to ensure they are correctly reported to stderr in CI/CD environments.

Comment thread packages/angular/build/src/builders/library/builder.ts Outdated
@alan-agius4 alan-agius4 removed the detected: feature PR contains a feature commit label Oct 8, 2026
…ry builder

Align library builder logs with the application builder format by logging:
- `Library bundle generation complete. [X seconds] - <timestamp>` on build completion
- `Output location: <outputPath>` for successful builds
- `Watch mode enabled. Watching for file changes...` after initial build when watch mode is active
@alan-agius4 alan-agius4 changed the title feat(@angular/build): enhance build logs and output location for library builder fix(@angular/build): enhance build logs and output location for library builder Oct 8, 2026
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Oct 8, 2026
Comment thread packages/angular/build/src/builders/library/builder.ts Outdated
Comment thread packages/angular/build/src/builders/library/tests/behavior/build_spec.ts Outdated
@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 13, 2026
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 13, 2026
@alan-agius4
alan-agius4 merged commit 2c518a6 into angular:main Oct 13, 2026
67 of 68 checks passed
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4
alan-agius4 deleted the feat-lib-build-logs branch October 13, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants