Repository navigation
Correct package and alert information links - #406
Open
John-David Dalton (jdalton) wants to merge 1 commit into
Open
John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
Use package destinations and alert-specific documentation in JSON and security comments. Preserve existing alert fields and omit links when their source value is missing. Assisted-by: Codex:GPT-6
John-David Dalton (jdalton)
added this pull request to stack #401
October 13, 2026 18:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Codex:GPT-6
Link security findings to the affected package and the matching alert documentation.
Root Cause
Security comments used package identifiers as links and sent every non-license finding to malware documentation. JSON did not distinguish package links from alert-type documentation.
Fix
package_urlandinfo_urlfields to standard JSON alerts.Builds on #405. Links to individual alerts and triage pages still require an authoritative API value.
Validation
41 focused tests pass, including actual Core/SDK requests against the approved localhost fixture. Scoped Ruff, formatting for touched sections, and diff checks pass. Independent source review found no blockers.
Public Changelog
Correct package and alert documentation links in security reports.
Note
Low Risk
Additive JSON fields and PR comment link fixes; no auth or scan logic changes, though strict JSON schema consumers may need to allow new keys.
Overview
Fixes incorrect “Read more” links in PR security comments (they previously used
purlfor “This package”, mislabeledurl, and sent many findings to generic malware/license pages). Comments now use a sharedbuild_alert_linkshelper: This package → existing alerturl, About this alert type →https://socket.dev/alerts/{type}(URL-encoded), omitting either link when missing.Standard
--enable-jsonalerts gain additive nullable fieldspackage_url(same asurl) andinfo_url(type docs);url,purl, and in-memory models are unchanged.docs/cli-reference.mddocuments the new JSON fields.Reviewed by Cursor Bugbot for commit 9b1a282. Configure here.