Skip to content

Carthage build fails when using XCFrameworks flag #56

Open

Description

@daltonclaybrook

Attempting to build SDWebImageWebPCode with Carthage using the --use-xcframeworks flag results in a build failure. The following error is observed in the log:

...SDImageWebPCoder.h:12:9: fatal error: module 'SDWebImage' not found
@import SDWebImage;
 ~~~~~~~^~~~~~~~~~
1 error generated.

The issue appears to be caused by incomplete FRAMEWORK_SEARCH_PATHS for SDWebImageWebPCoder. Presently, this build setting includes the platform-specific build folder (e.g. $(PROJECT_DIR)/Carthage/Build/iOS) but does not include the root build folder ($(PROJECT_DIR)/Carthage/Build), which is where XCFrameworks are located.

Activity

  1. dreampiggy commented on May 6, 2021

    @dreampiggy
    Contributor

    That #57 merged. I'll release a patch version 0.8.4

    However, is this only thing to do that support Carthage with XCFramework ?

    I remember the issue talked here: Carthage/Carthage#3019 (comment)

    Carthage need all the downstream component, to update their Xcode and create a new scheme "Like SDWebImage XCFramework" and add dependency to that.

  2. daltonclaybrook commented on May 6, 2021

    @daltonclaybrook
    ContributorAuthor

    This is not the case in my experience. For example, SDWebImage and other dependencies build fine as XCFrameworks already.

    SDWebImageWebPCoder build console

  3. dreampiggy commented on May 7, 2021

    @dreampiggy
    Contributor

    Looks great. If Carthage's XCFramework adoptation does not cost too much of maintainess issues, I can update all SDWebImage related components together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions