fix: bare except in checkpoint loader swallows KeyboardInterrupt

[andrewwhitecdw]

This PR addresses the following issue in train.py: bare except in checkpoint loader swallows KeyboardInterrupt.

Changes

• train.py: bare except in checkpoint loader swallows KeyboardInterrupt.

Details

--- a/train.py
+++ b/train.py
@@ -1,1 +1,1 @@
-        except:
+        except Exception:

Tests

• tests/test_no_bare_except.py

--- /dev/null
+++ b/tests/test_no_bare_except.py
@@ -0,0 +1,17 @@
+import ast
+import os
+import unittest
+
+
+class TestNoBareExcept(unittest.TestCase):
+    def test_train_py_has_no_bare_except(self):
+        path = os.path.join(os.path.dirname(__file__), '..', 'train.py')
+        with open(path) as f:
+            tree = ast.parse(f.read())
+        bare_handlers = [
+            node.lineno
+            for node in ast.walk(tree)
+            if isinstance(node, ast.ExceptHandler) and node.type is None
+        ]
+        self.assertEqual(bare_handlers, [], "train.py contains bare except: handlers")
+
+
+if __name__ == '__main__':
+    unittest.main()

[andrewwhitecdw]

Closing after multiple repair attempts: original patch no longer applies or auditor feedback remains unaddressed.

[andrewwhitecdw]

script closed on accident