Duplicate contexts do not throw IllegalArgumentException [EXTERNAL ISSUE] #86

Activity

1. Katsute

   added

   bugSomething isn't working as expectedSomething isn't working as expected

   on Aug 10, 2020
2. Katsute

   added 2 commits that reference this issue on Aug 27, 2020

   Fix #86

   This issue will close once commit 16b5abe is merged into the 'main' branch.

   16b5abe

   Unfixed #86

   ...

   This issue will close once commit 226f8c6 is merged into the 'main' branch.

   226f8c6
3. Katsute commented on Aug 27, 2020

   

   Katsute

   on Aug 27, 2020

   MemberAuthor

   More actions

   Multiple tests have been run against the #create method in the sun http server library; but the illargs exception is only thrown for specific contexts, not all. This is a dependency issue and can not be resolved by SimpleHttpServer
4. Katsute

   added

   droppedThis is not being worked onThis is not being worked on

   on Aug 27, 2020
5. Katsute

   closed this as completedin 16b5abeon Aug 28, 2020
6. Katsute

   reopened this on Aug 28, 2020
7. Katsute

   pinned this issue on Aug 28, 2020
8. Ktt-Development

   locked as off topic and limited conversation to collaborators on Aug 30, 2020
9. Katsute

   unpinned this issue on Sep 20, 2020
10. Katsute commented on Sep 29, 2020

    

    Katsute

    on Sep 29, 2020

    MemberAuthor

    More actions

    According to the source code an IllegalArgumentException is never thrown for duplicate contexts. The documentation on this method is invalid.

    sun.net.httpserver.ServerImpl

    ...
        public synchronized HttpContextImpl createContext (String path, HttpHandler handler) {
            if (handler == null || path == null) {
                throw new NullPointerException ("null handler, or path parameter");
            }
            HttpContextImpl context = new HttpContextImpl (protocol, path, handler, this);
            contexts.add (context);
            logger.log (Level.DEBUG, "context created: " + path);
            return context;
        }
    ...

    sun.net.httpserver.HttpContextImpl

    ...
        HttpContextImpl (String protocol, String path, HttpHandler cb, ServerImpl server) {
            if (path == null || protocol == null || path.length() < 1 || path.charAt(0) != '/') {
                throw new IllegalArgumentException ("Illegal value for path or protocol");
            }
            this.protocol = protocol.toLowerCase();
            this.path = path;
            if (!this.protocol.equals ("http") && !this.protocol.equals ("https")) {
                throw new IllegalArgumentException ("Illegal value for protocol");
            }
            this.handler = cb;
            this.server = server;
            authfilter = new AuthFilter(null);
            sfilters.add (authfilter);
        }
    ...
11. Katsute

    closed this as completedon Sep 29, 2020
12. Katsute

    pinned this issue on Sep 29, 2020