Repository navigation
Make dialect-specific clause words non-reserved - #2793
Merged
manticore-projects merged 1 commit intoOct 13, 2026
Merged
Conversation
CSV, FBV, FILE, SCRIPT and VERIFY (Exasol IMPORT/EXPORT), PREWHERE and SETTINGS (ClickHouse) and RETURNS (CREATE FUNCTION) were reserved for every dialect, so `SELECT settings, file FROM t` failed in PostgreSQL or DuckDB, where they are ordinary names. They are now non-reserved. PREWHERE and SETTINGS never start an implicit alias, so the ClickHouse clauses still follow a table name. TypeDdlName's SETTINGS special case and FILE's entry in the reserved-as-identifier list are no longer needed.
Contributor
|
Nice, ready to merge when tests confirmed. |
Contributor
Author
|
@manticore-projects CI passes |
Contributor
|
Thank you much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the discussion in #2787: the smaller fix, without per-dialect keyword lists.
CSV,FBV,FILE,SCRIPT,VERIFY(ExasolIMPORT/EXPORT),PREWHERE,SETTINGS(ClickHouse) andRETURNS(CREATE FUNCTION) were reserved for every dialect, so this failed everywhere although they are ordinary names in PostgreSQL or DuckDB:NonReservedWord().PREWHEREandSETTINGSnever start an implicit alias, soFROM t PREWHERE …/FROM t SETTINGS …still parse as clauses (AS settingsstill works).SETTINGSspecial case inTypeDdlName()andFILEin the reserved-as-identifier lists.checkGrammarAmbiguity: no new choice conflicts../gradlew check: 10,132 tests, 0 failures; ExasolIMPORT/EXPORTand ClickHouse tests unchanged..sqltest resources, best of 30 rounds, ~34 ms on both master and this branch.Refs #2786