Repository navigation
Allow ERRORS as an unquoted identifier - #2781
Merged
manticore-projects merged 1 commit intoOct 13, 2026
Merged
Conversation
`ERRORS` was declared in the reserved keyword block when the Exasol IMPORT/EXPORT error clauses were added (JSQLParser#2256), so 5.4 rejects queries using it as a name, e.g. `SELECT errors FROM t` or a `WITH errors AS (...)` CTE, which DuckDB, PostgreSQL and most databases accept. Its only uses, `ERRORS INTO ...` and `REJECT LIMIT n ERRORS`, are behind lookaheads, so it moves to the non-reserved keywords next to `ERROR`. The Exasol IMPORT/EXPORT tests still pass.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow
ERRORSas an unquoted identifier again. 5.4 rejects queries using it as a name, e.g.SELECT errors FROM tor aWITH errors AS (...)CTE, which DuckDB, PostgreSQL and most databases accept. We hit it on real DuckDB queries: 142 of ~500 production queries use anerrorscolumn.Cause
ERRORSwas declared in the reserved keyword block when the Exasol IMPORT/EXPORT error clauses were added (#2256). Its only uses,ERRORS INTO ...andREJECT LIMIT n ERRORS, sit behind lookaheads.Change
K_ERRORSintoNonReservedWord(), next toERROR.keywords.rst.KeywordsTest#testErrorsAsIdentifier: column, qualified column, alias, CTE and table column names.Validation
check: 10,043 tests, zero failures/errors; Spotless, Checkstyle, PMD and SpotBugs pass.ExportTestandImportTest(246 tests, including theERRORS INTOandREJECT LIMIT n ERRORScases) pass unchanged.Cc @manticore-projects