From 703874875309fa0f7ac112234ca93ced279e9ec0 Mon Sep 17 00:00:00 2001 From: Karol Trzcinski Date: Fri, 25 Oct 2019 08:36:50 +0200 Subject: [PATCH] ipc: Break ipc_comp_dai_config after first error Added break statement after error, as it was before refactoring this part of code in commit <89ef0af07612c0bcf1a85fec3871d0c31e60087b> ("ipc: Refactor ipc_comp_dai_config function"). While at it, also removed additional parenthesis around trace_ipc_error. Signed-off-by: Karol Trzcinski --- src/ipc/ipc.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ipc/ipc.c b/src/ipc/ipc.c index 5ec87b083e8a..39fbb94afa45 100644 --- a/src/ipc/ipc.c +++ b/src/ipc/ipc.c @@ -453,15 +453,17 @@ int ipc_comp_dai_config(struct ipc *ipc, struct sof_ipc_dai_config *config) * config dai_index. */ if (dai->dai_index == config->dai_index && - dai->type == config->type) + dai->type == config->type) { ret = comp_dai_config(icd->cd, config); + if (ret < 0) + break; + } } } - if (ret < 0) { + if (ret < 0) trace_ipc_error("ipc_comp_dai_config() error: " "comp_dai_config() failed"); - } return ret; }