Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

feat(alerts): tabs for filtering table - #234

Merged
lxmcgvrn merged 7 commits into
mainfrom
feat/alerts/tabs-for-table
Jan 31, 2025
Merged

lxmcgvrn merged 7 commits into
mainfrom
feat/alerts/tabs-for-table

Conversation

@lxmcgvrn

Copy link
Copy Markdown
Contributor
  • adds tabs to toggle between different types of alerts
  • moves filtering & pagination logic into searchParams (only 2 usages of zustand left 🙌🏻)
Screen.Recording.2025-01-30.at.3.16.05.PM.mov

@coveralls

coveralls commented Jan 30, 2025 •

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 13069930661

Details

  • 22 of 23 (95.65%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 73.779%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/alerts/components/table-alerts.tsx 1 2 50.0%
Totals Coverage Status
Change from base Build 13069922467: 0.5%
Covered Lines: 784
Relevant Lines: 996

💛 - Coveralls

@peppescg

Copy link
Copy Markdown
Collaborator

There is something weird looking to the video, the total number of alerts are 22, but malicious + secrets are 38 🤔

@lxmcgvrn
lxmcgvrn merged commit 2765917 into main Jan 31, 2025
@lxmcgvrn
lxmcgvrn deleted the feat/alerts/tabs-for-table branch January 31, 2025 09:37
@jtenniswood

Copy link
Copy Markdown

What happens when you search within a filtered view?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants