GUI - keep the metronome compact: size its dock to its controls rather than a fixed height

Author: samaaron

app/gui/mainwindow.cpp

@@ -1060,14 +1060,7 @@ void MainWindow::setupWindowStructure()
     metroWidget->setFocusPolicy(Qt::NoFocus);
     metroWidget->setFeatures(QDockWidget::NoDockWidgetFeatures);
     metroWidget->setAllowedAreas(Qt::RightDockWidgetArea);
-    metroWidget->setMaximumHeight(ScaleHeightForDPI(110));
-    metroWidget->setWidget(metroPane);
-    // Let the dock grow when the streams panel expands, shrink on collapse.
-    connect(metroPane, &SonicPiMetro::linkAudioStreamsExpandedChanged, this,
-            [this](bool expanded) {
-                metroWidget->setMaximumHeight(
-                    expanded ? QWIDGETSIZE_MAX : ScaleHeightForDPI(110));
-            });
+    metroWidget->setWidget(metroPane);   // as tall as the pane needs (SonicPiMetro::fitHeightToContent)
 
     addDockWidget(Qt::RightDockWidgetArea, outputWidget);
     addDockWidget(Qt::RightDockWidgetArea, incomingWidget);

app/gui/widgets/sonicpimetro.cpp

@@ -251,6 +251,7 @@ SonicPiMetro::SonicPiMetro(std::shared_ptr<SonicPi::QtAPIClient> spClient, std::
   metro_layout->addStretch(1);
   metro_layout->addWidget(linkColumn, 0, Qt::AlignLeft);
   setLayout(metro_layout);
+  fitHeightToContent(false);
 
   // Restore visibility scope from QSettings (Local default). Link enable
   // is not persisted: joining a mesh is a per-session opt-in.
@@ -520,18 +521,28 @@ void SonicPiMetro::setFocusTimeWarpScrubber()
   timeWarpLineEdit->setVisible(true);
 }
 
+// Compact unless the streams panel is open: no taller than the row of controls
+// needs, so the dock it sits in is as tall as its title and that row, whatever
+// the font and zoom, and no band of empty space opens above the controls. Open,
+// the panel may take what the dock can give it.
+void SonicPiMetro::fitHeightToContent(bool streamsOpen)
+{
+  setSizePolicy(QSizePolicy::Preferred, streamsOpen ? QSizePolicy::Preferred : QSizePolicy::Maximum);
+  updateGeometry();
+}
+
 void SonicPiMetro::toggleLinkAudioStreams()
 {
   if (!linkStreamsWidget) return;
   const bool nowVisible = !linkStreamsWidget->isVisible();
   linkStreamsWidget->setVisible(nowVisible);
   linkStreamsButton->setChecked(nowVisible);
+  fitHeightToContent(nowVisible);
   // ↓ when expanded, ↑ when collapsed.
   linkStreamsButton->setText(nowVisible
       ? QString::fromUtf8("\xe2\x86\x93")
       : QString::fromUtf8("\xe2\x86\x91"));
   linkStreamsButton->setAccessibleName(nowVisible
       ? tr("Hide Link Audio streams panel")
       : tr("Show Link Audio streams panel"));
-  emit linkAudioStreamsExpandedChanged(nowVisible);
 }

app/gui/widgets/sonicpimetro.h

@@ -58,10 +58,6 @@ class SonicPiMetro : public QWidget
   // network visibility). MainWindow routes this to the status bar and the
   // screen reader via showStatusAndAnnounce().
   void statusMessage(const QString& message);
-  // Emitted when the inline Link Audio Streams panel is shown/hidden.
-  // MainWindow listens to resize the surrounding dock — the metro
-  // dock is hard-capped to a small height when collapsed.
-  void linkAudioStreamsExpandedChanged(bool expanded);
 
 public slots:
   void tapTempo(int flashDelay=250);
@@ -74,6 +70,7 @@ public slots:
   void paintEvent(QPaintEvent *event);
 
 private:
+  void fitHeightToContent(bool streamsOpen);
   QPushButton *enableLinkButton = nullptr;
   QPushButton *linkStreamsButton;
   QPushButton *tapButton;