Repository navigation
fix(analyzer): Use dedicated storage for abstract static edges - #364
Merged
Merged
Conversation
Saloed
added a commit
that referenced
this pull request
Aug 20, 2026
Adapted from upstream cbe3b3f ("fix(analyzer): Use dedicated storage for abstract static edges (#364)"). An edge whose initial and final access paths are both the depth-0 ClassStatic access carries no access-path information at all - only its exclusion set is ever interesting. Kept in the general initial-to-final storage, one such edge is recorded per distinct exclusion set per statement, and on a project with many static pseudo-variables that storage dominates the per-method edge set. AbstractStaticEdges replaces the whole family at a statement with a single exclusion set: adding an edge unions into it and reports a delta only when the union grows, and the read paths rebuild the (initial, final) pair from the manager's most-abstract access paths. addTaintedFactEdge and the class-static branch of addFactToFactSupports route to it via isAbstractStaticEdge, and the three collectApAtStatement overloads consult it before the general storage. Two adaptations were needed against upstream: - on this branch MethodEdgesInitialToFinalApSet.add returns a List of changed (initial, final) pairs rather than a nullable Pair, because BaseOnly layered summaries need every changed final, so the override returns a singleton list or an empty list instead of a value or null. - addFactToFactSupports does not exist upstream, so upstream could not route it. It is the second producer of abstract static edges here, and routing only addTaintedFactEdge would leave the two storages disagreeing about which edges exist; its ClassStatic depth-0 case now dispatches per initial fact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/seqra/opentaint-test/actions/runs/32297067512