Repository navigation
fix(chezmoi): preserve Satty archive paths - #1130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Satty v0.22.0 ships its binary and completions without an enclosing directory. Chezmoi normalizes the archive's leading
./, sostripComponents = 1strips thecompletions/directory and makescompletions/satty.fishfail to resolve. This breaks the chezmoi init check on unrelated Renovate PRs, including #1128.Remove
stripComponentsfrom both Satty archive-file entries so their paths match the release archive.Validation: reproduced the completion extraction failure with chezmoi v2.73.3; removing
stripComponentssuccessfully extracted the 5,452-byte fish completion. Full init validation is left to this PR's CI.