From 2c4ecf3e068ab0b97ae3e395e29add7e6d43a6ff Mon Sep 17 00:00:00 2001 From: Nicolei Sagun Date: Tue, 27 Oct 2026 09:51:29 +0800 Subject: [PATCH 1/2] fix(console): prevent TypeError on component unmount in useEventListener --- .../packages/console-shared/src/hooks/useEventListener.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frontend/packages/console-shared/src/hooks/useEventListener.ts b/frontend/packages/console-shared/src/hooks/useEventListener.ts index a25949ce954..9b8f00f36cc 100644 --- a/frontend/packages/console-shared/src/hooks/useEventListener.ts +++ b/frontend/packages/console-shared/src/hooks/useEventListener.ts @@ -1,11 +1,13 @@ import { useEffect } from 'react'; export const useEventListener = ( - target: EventTarget, + target: EventTarget | null | undefined, // <-- Safe type definition event: keyof WindowEventMap | keyof DocumentEventMap, callback: EventListener, ) => { useEffect(() => { + if (!target) return; // <-- Safe guard against null/undefined targets! + target.addEventListener(event, callback); return () => { target.removeEventListener(event, callback); From b1d41dfe2177fd6afdb4a3a7857ffeb62e0caa68 Mon Sep 17 00:00:00 2001 From: Nicolei Sagun Date: Tue, 27 Oct 2026 10:47:23 +0800 Subject: [PATCH 2/2] fix(console): exit fullscreen mode before unmounting on cancel --- frontend/public/components/edit-yaml.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/frontend/public/components/edit-yaml.tsx b/frontend/public/components/edit-yaml.tsx index 6c16ca00f50..2c3cee82cca 100644 --- a/frontend/public/components/edit-yaml.tsx +++ b/frontend/public/components/edit-yaml.tsx @@ -954,6 +954,9 @@ const EditYAMLInner: FC = (props) => { id="cancel" data-test="cancel" onClick={() => { + if (isFullscreen) { + toggleFullscreen(); + } onCancel(); dispatch(closeOLS()); }}