From b203d3b4a9b01cae7273864f66aa6d30061b23c9 Mon Sep 17 00:00:00 2001 From: Ivan Bochkarev Date: Thu, 13 Aug 2026 23:23:31 +0600 Subject: [PATCH] fix(vue): reuse ms3_menu_remove for product link confirm header The title key ms3_menu_remove_title does not exist. The confirm body already uses manager lexicon; the same Remove string is enough. --- .../components/minishop3/tests/ProductLinksVueTabTest.php | 8 ++++++++ vueManager/src/components/product/ProductLinksTab.vue | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/core/components/minishop3/tests/ProductLinksVueTabTest.php b/core/components/minishop3/tests/ProductLinksVueTabTest.php index 29948f088..73804f173 100644 --- a/core/components/minishop3/tests/ProductLinksVueTabTest.php +++ b/core/components/minishop3/tests/ProductLinksVueTabTest.php @@ -86,6 +86,14 @@ $assertTrue(is_file($vue . '/components/product/ProductLinksTab.vue'), 'ProductLinksTab.vue missing'); $assertTrue(str_contains($linksTab, 'ConfirmDialog'), 'ConfirmDialog belongs in ProductLinksTab'); $assertTrue(str_contains($linksTab, '/api/mgr/references/link-types'), 'link-types via references'); +$assertTrue( + !str_contains($linksTab, 'ms3_menu_remove_title'), + 'confirm header must not use missing ms3_menu_remove_title (#556)' +); +$assertTrue( + str_contains($linksTab, "header: _('ms3_menu_remove')"), + 'confirm header must reuse existing ms3_menu_remove (#556)' +); $updateCtrl = (string) file_get_contents($root . '/controllers/product/update.class.php'); $assertTrue( diff --git a/vueManager/src/components/product/ProductLinksTab.vue b/vueManager/src/components/product/ProductLinksTab.vue index 9b87cc1b3..fdc79e6e2 100644 --- a/vueManager/src/components/product/ProductLinksTab.vue +++ b/vueManager/src/components/product/ProductLinksTab.vue @@ -185,7 +185,7 @@ async function saveLink(close = true) { function removeLink(row) { confirm.require({ message: _('ms3_menu_remove_confirm'), - header: _('ms3_menu_remove_title'), + header: _('ms3_menu_remove'), icon: 'pi pi-exclamation-triangle', acceptLabel: _('delete'), rejectLabel: _('cancel'),