[Kentzo]

Here I'm going to address remaining issues by merging changes from my diverged fork that made Protobuf 2.5.1 compatible with Python 3 by retaining compatibility with all other supported versions.

I kindly ask authorized developers to review and leave comments and I'll try to address them as soon as I can.

A few questions:

• Did you loose the requirements for minimum Python 2 version?
• Most tests are missing here: https://github.com/GreatFruitOmsk/protobuf/blob/master/python/setup.py#L100-L102. Why?

[xfxyjwf]

+ @mrovner to help take a look.

[tseaver]

+1. Replacing the old, Python2-only 'ez_setup.py' with one from the setuptools bitbucket repo is definitely the Right Thing. FTR, the permalink for "latest and greatest" ez_setup.py is: https://bootstrap.pypa.io/ez_setup.py

[tseaver]

Is this change related to the Python3 port, or is it just ensuring better coverage of what the testcase name says it is about?

[Kentzo]

@xfxyjwf @mrovner Do we still need to support Python 2.5 in protobuf 2.6+ ?

[mrovner]

Yes, we still have 2.5 clients.

On Tue, Nov 18, 2014 at 8:53 AM, Ilya Kulakov notifications@github.com
wrote:

@xfxyjwf https://github.com/xfxyjwf @mrovner
https://github.com/mrovner Do we still need to support Python 2.6 in
protobuf 2.6+ ?

—
Reply to this email directly or view it on GitHub
#66 (comment).

Thanks,
--Mike

[Kentzo]

@tseaver Please edit your reviews given that answer :)

[tseaver]

@mrovner I thought the question was about keeping 2.6 support: are you saying that we need to ship a protobuf that spans 2.5 through 3.4?

Would bumping a major version to signal dropping 2.5 support while adding 3.x support be reasonable? Users stuck on Python 2.5 would then stay with protobuf 2.6.x, while those who needed Py3k could move to protobuf 2.7.x.

[virtuald]

Might make more sense to move this block up to line 44, instead of having the if statement down here.

[sebastianludwig]

Is there any way to support this pull request?

[tseaver]

I note that the master is no aiming at a 3.0.0 release: that would seem like an ideal time to drop support for Python < 2.6.

[tseaver]

Given that we rely on setuptools (boostrapping from ez_setup.py if it isn't present), we should be able to use its find_packages() rather than enumerating modules by hand.

[davidB]

Hi,

Until support of python, I share my workaround, a script to convert to python3:

# more info at http://python3porting.com/bookindex.html
# download protobuf-2.6.1.tar.gz for python
cd modules
rm -Rf google
tar -xzvf ~/Téléchargements/protobuf-2.6.1.tar.gz protobuf-2.6.1/google
2to3-3.4 protobuf-2.6.1/google -o google -W --no-diffs -p -n
rm -Rf protobuf-2.6.1

2to3 is a tool provide by python3.
I used it be able to use protobuf with bendler (blender 2.72 include python 3.4.2)

[Kentzo]

@mrovner I believe this PR can be closed without merging. Please confirm.

[tamird]

@Kentzo protobuf now officially doesn't need to support python 2.5 and 2.6. Would you like to rebase this such that only 2.7+ is supported?

[Kentzo]

@tamird I don't have time to review that right now. We don't plan to migrate to 2.6 anytime soon.

Any help is welcome :)

[tamird]

@haberman probably time to close this guy :)

[haberman]

Ah yes, this has been addressed in other changes. Closing now.