Skip to content

Fixing incorrect detection of the NewLisp language - #2319

Closed
Ignotus wants to merge 1 commit into
github-linguist:masterfrom
Ignotus:master
Closed

Ignotus wants to merge 1 commit into
github-linguist:masterfrom
Ignotus:master

Conversation

@Ignotus

@Ignotus Ignotus commented Apr 9, 2015

Copy link
Copy Markdown

The proposed sample file that contains tokenized Dutch words has been wrongly recognized as a NewLisp code in my repository.

This patch is a try to fix this ambiguity.

@pchaigno

pchaigno commented Apr 9, 2015

Copy link
Copy Markdown
Contributor

Isn't the classifier sufficient to solve this issue? I.e., does adding new samples solve it?
Otherwise, have you tested that this new heuristic doesn't break recognition of NewLisp files?

@Ignotus

Ignotus commented Apr 9, 2015

Copy link
Copy Markdown
Author

Yeah, you can try to check

bundle exec linguist samples/Text/corpus_1000.nl

No, I only tested on unit tests.

@pchaigno

pchaigno commented Apr 9, 2015

Copy link
Copy Markdown
Contributor

Yeah, you can try to check

bundle exec linguist samples/Text/corpus_1000.nl

The files used for training should always be recognized correctly (otherwise there's something really wrong with the classifier). Do you have some other files wrongly detected as NewLisp?

@Ignotus

Ignotus commented May 6, 2015

Copy link
Copy Markdown
Author

No, unfortunately. I have fixed in my project by adding .gitattributes. Probably I will create another pull request in the case if I will have enough data to test in the future.

@Ignotus Ignotus closed this May 6, 2015
@arfon arfon mentioned this pull request May 15, 2015
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants