From f4ddfd02a56d54838140dc269b09af5a34d25077 Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Tue, 17 Jun 2025 14:55:07 +0000 Subject: [PATCH 1/4] Windows, fix: `export' is not recognized as an internal or external command. --- eng/testing/xunit/xunit.console.targets | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/testing/xunit/xunit.console.targets b/eng/testing/xunit/xunit.console.targets index b682117b75a9ec..89567bb43fef81 100644 --- a/eng/testing/xunit/xunit.console.targets +++ b/eng/testing/xunit/xunit.console.targets @@ -13,8 +13,8 @@ - - + + From 7273e9f2fb9f6c559a839e4cbcd941c85a075433 Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz Date: Wed, 18 Jun 2025 13:46:33 +0200 Subject: [PATCH 2/4] Unify setting env var in lib tests. --- eng/testing/tests.browser.targets | 35 +++++++++---------------- eng/testing/tests.props | 7 +++-- eng/testing/tests.targets | 3 +-- eng/testing/tests.wasi.targets | 10 +++---- eng/testing/xunit/xunit.console.targets | 3 +-- 5 files changed, 22 insertions(+), 36 deletions(-) diff --git a/eng/testing/tests.browser.targets b/eng/testing/tests.browser.targets index 4264bde6d01999..911719ab33faa6 100644 --- a/eng/testing/tests.browser.targets +++ b/eng/testing/tests.browser.targets @@ -71,22 +71,16 @@ Any settings in the project file could be replaced on Helix. See also eng\testing\WasmRunnerTemplate.sh --> - - - - - - + + + + + - + - - - - - - - + + @@ -251,15 +245,10 @@ Text="Only supported scenarios are WasmTestOnV8, WasmTestOnChrome, WasmTestOnFirefox and BuildWasmApps at the moment. It was $(Scenario)." /> - - - - - - - - - + + + + diff --git a/eng/testing/tests.props b/eng/testing/tests.props index ad0f25da5fa054..5ff71ec66cc51f 100644 --- a/eng/testing/tests.props +++ b/eng/testing/tests.props @@ -9,6 +9,10 @@ $(MSBuildThisFileDirectory)ILLinkDescriptors\ true true + set + export + \\ + / @@ -27,8 +31,7 @@ - - + diff --git a/eng/testing/tests.targets b/eng/testing/tests.targets index f05b4aa2a67c7b..f7fb50dced1c5f 100644 --- a/eng/testing/tests.targets +++ b/eng/testing/tests.targets @@ -71,8 +71,7 @@ - - + diff --git a/eng/testing/tests.wasi.targets b/eng/testing/tests.wasi.targets index 066c4391ad4503..52f72440d76d72 100644 --- a/eng/testing/tests.wasi.targets +++ b/eng/testing/tests.wasi.targets @@ -151,13 +151,9 @@ '$(Scenario)' != 'BuildWasmApps'" Text="Only supported scenarios are WasmTestOnWasmtime and BuildWasmApps at the moment. It was $(Scenario)." /> - - - - - - - + + + diff --git a/eng/testing/xunit/xunit.console.targets b/eng/testing/xunit/xunit.console.targets index 89567bb43fef81..cb79571f2f1d5c 100644 --- a/eng/testing/xunit/xunit.console.targets +++ b/eng/testing/xunit/xunit.console.targets @@ -13,8 +13,7 @@ - - + From 0d38e7ed2d9a7f3b335bcb3b76fd9cd78b8b4297 Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz Date: Mon, 24 Nov 2025 11:46:48 +0100 Subject: [PATCH 3/4] Remaining optimization. --- src/libraries/sendtohelix-browser.targets | 40 ++++++++++------------- src/libraries/sendtohelix-wasi.targets | 23 +++++++------ src/libraries/sendtohelix-wasm.targets | 25 ++++++-------- 3 files changed, 39 insertions(+), 49 deletions(-) diff --git a/src/libraries/sendtohelix-browser.targets b/src/libraries/sendtohelix-browser.targets index eba7ec0e95f2c7..d3a92fbac1e7bf 100644 --- a/src/libraries/sendtohelix-browser.targets +++ b/src/libraries/sendtohelix-browser.targets @@ -91,30 +91,26 @@ /> - - - - - + + + + + - - - - - + + + + + + - - - - - - - - - - + + + + + @@ -129,8 +125,8 @@ - - + + diff --git a/src/libraries/sendtohelix-wasi.targets b/src/libraries/sendtohelix-wasi.targets index ccb4e68c2db60c..a4aefcfdeab107 100644 --- a/src/libraries/sendtohelix-wasi.targets +++ b/src/libraries/sendtohelix-wasi.targets @@ -61,22 +61,21 @@ dotnet-none + + + + + + + - - - - - - - - - - + + @@ -86,8 +85,8 @@ - - + + diff --git a/src/libraries/sendtohelix-wasm.targets b/src/libraries/sendtohelix-wasm.targets index 3a8b618f54f3d9..9ad6d03cc16adf 100644 --- a/src/libraries/sendtohelix-wasm.targets +++ b/src/libraries/sendtohelix-wasm.targets @@ -7,6 +7,9 @@ $([MSBuild]::NormalizeDirectory($(BrowserProjectRoot), 'build')) $([MSBuild]::NormalizeDirectory($(WasmProjectRoot), 'build')) + + set + export @@ -20,20 +23,13 @@ - - - - - - - - - - - + + - - + + + + @@ -53,8 +49,7 @@ $(_BuildWasmAppsPayloadArchive) - set "HELIX_XUNIT_ARGS=-class %(Identity)" - export "HELIX_XUNIT_ARGS=-class %(Identity)" + $(EnvVarCommand) "HELIX_XUNIT_ARGS=-class %(Identity)" $(HelixCommand) $(_workItemTimeout) From 08a0e0947c5551c8c2a239a13f4c13d83155c97a Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Mon, 24 Nov 2025 13:10:27 +0000 Subject: [PATCH 4/4] Fix syntax. --- src/libraries/sendtohelix-browser.targets | 24 +++++++++++------------ src/libraries/sendtohelix-wasi.targets | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/libraries/sendtohelix-browser.targets b/src/libraries/sendtohelix-browser.targets index d3a92fbac1e7bf..fe3efe43b7a095 100644 --- a/src/libraries/sendtohelix-browser.targets +++ b/src/libraries/sendtohelix-browser.targets @@ -98,19 +98,19 @@ - - - - - + + + + + - - - - - + + + + + @@ -125,8 +125,8 @@ - - + + diff --git a/src/libraries/sendtohelix-wasi.targets b/src/libraries/sendtohelix-wasi.targets index a4aefcfdeab107..44500dfaad7b7b 100644 --- a/src/libraries/sendtohelix-wasi.targets +++ b/src/libraries/sendtohelix-wasi.targets @@ -74,8 +74,8 @@ - - + +