From 18b5d975e0dd8b4896ba5fe6c6a0e901bf640bf5 Mon Sep 17 00:00:00 2001 From: Tony Germano Date: Thu, 22 Oct 2026 22:39:37 -0400 Subject: [PATCH] Drop the unused netty-reactive-streams jars The com.typesafe.netty netty-reactive-streams and netty-reactive-streams-http 2.0.8 jars in aws/ext/netty hold an implementation of the Reactive Streams interfaces for Netty. netty-nio-client includes its own copy of that implementation under software.amazon.awssdk.http.nio.netty.internal.nrs, credited in its NOTICE, so the separate jars are no longer used. The copy covers every class of the two jars except the server and WebSocket ones (HttpStreamsServerHandler, WebSocketHttpResponse and DefaultWebSocketHttpResponse), which an HTTP client does not need. No class in any other jar of the distribution references com.typesafe.netty, and no service or configuration file names it. Remove them from the catalog, the server bundle and the vendored layout, and drop com.typesafe.netty from the Renovate netty group. reactive-streams stays: it holds the interfaces being implemented (Publisher, Subscriber, Subscription), which netty-nio-client and the SDK core still use. Checksums regenerated with a cold cache per CONTRIBUTING.md. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Tony Germano --- gradle/libs.versions.toml | 5 ----- gradle/vendored-layout.json | 2 -- gradle/verification-metadata.xml | 21 --------------------- renovate.json | 3 +-- 4 files changed, 1 insertion(+), 30 deletions(-) diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 9eb0f3a5db..24df7a0e54 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -33,7 +33,6 @@ log4j = "2.26.1" miglayout = "4.2" mockito = "5.1.1" netty = "4.1.137.Final" -netty-reactive-streams = "2.0.8" openhtmltopdf = "1.0.9" pdfbox = "2.0.24" slf4j = "1.7.30" @@ -219,8 +218,6 @@ netty-codec-http = { module = "io.netty:netty-codec-http", version.ref = "netty" netty-codec-http2 = { module = "io.netty:netty-codec-http2", version.ref = "netty" } netty-common = { module = "io.netty:netty-common", version.ref = "netty" } netty-handler = { module = "io.netty:netty-handler", version.ref = "netty" } -netty-reactive-streams = { module = "com.typesafe.netty:netty-reactive-streams", version.ref = "netty-reactive-streams" } -netty-reactive-streams-http = { module = "com.typesafe.netty:netty-reactive-streams-http", version.ref = "netty-reactive-streams" } netty-resolver = { module = "io.netty:netty-resolver", version.ref = "netty" } netty-transport = { module = "io.netty:netty-transport", version.ref = "netty" } netty-transport-native-epoll = { module = "io.netty:netty-transport-native-epoll", version.ref = "netty" } @@ -608,8 +605,6 @@ server-main = [ "netty-codec-http2", "netty-common", "netty-handler", - "netty-reactive-streams", - "netty-reactive-streams-http", "netty-resolver", "netty-transport", "netty-transport-native-unix-common", diff --git a/gradle/vendored-layout.json b/gradle/vendored-layout.json index 7bffae2a4d..c64230af54 100644 --- a/gradle/vendored-layout.json +++ b/gradle/vendored-layout.json @@ -199,8 +199,6 @@ "com.sun.xml.ws:jaxws-tools": "javax/jaxws", "com.sun.xml.ws:policy": "javax/jaxws/ext", "com.thoughtworks.xstream:xstream": "", - "com.typesafe.netty:netty-reactive-streams": "aws/ext/netty", - "com.typesafe.netty:netty-reactive-streams-http": "aws/ext/netty", "com.zaxxer:HikariCP": "", "commons-beanutils:commons-beanutils": "commons", "commons-cli:commons-cli": "commons", diff --git a/gradle/verification-metadata.xml b/gradle/verification-metadata.xml index a55f913c97..5b47dff129 100644 --- a/gradle/verification-metadata.xml +++ b/gradle/verification-metadata.xml @@ -724,27 +724,6 @@ - - - - - - - - - - - - - - - - - - - - - diff --git a/renovate.json b/renovate.json index 9c37dfb451..d03bc7b1a8 100644 --- a/renovate.json +++ b/renovate.json @@ -84,8 +84,7 @@ { "groupName": "netty", "matchPackageNames": [ - "io.netty*", - "com.typesafe.netty*" + "io.netty*" ] }, {