Skip to content

Remove WeakMap/WeakSet#clear method #6500

Closed
Closed
Remove WeakMap/WeakSet#clear method#6500
Labels
Breaking ChangeWould introduce errors in existing codeBugA bug in TypeScriptDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issueGood First IssueWell scoped, documented and has the green lightHelp WantedYou can do this
Milestone
TypeScript 1.8

Description

@falsandtru
falsandtru (falsandtru)
opened on Jan 15, 2016

changes:

// lib.es6.d.ts and lib.core.es6.d.ts
// also WeakSet
 interface WeakMap<K, V> {
-    clear(): void;
     delete(key: K): boolean;
     get(key: K): V;
     has(key: K): boolean;
     set(key: K, value?: V): WeakMap<K, V>;
     [Symbol.toStringTag]: "WeakMap";
 }

https://tc39.github.io/ecma262/#sec-weakmap-constructor
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap
https://bugzilla.mozilla.org/show_bug.cgi?id=1101817

Activity

  1. Ryan Cavanaugh (RyanCavanaugh)
    added
    BugA bug in TypeScript
    Help WantedYou can do this
    Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScript
    on Jan 15, 2016
  2. Mohamed Hegazy (mhegazy)
    added
    Breaking ChangeWould introduce errors in existing code
    on Jan 17, 2016

  3. LPGhatguy commented on Jan 18, 2016

    @LPGhatguy
    Lucien Greathouse (LPGhatguy)
    on Jan 18, 2016
    Contributor

    What runtime environments have this implemented?

    I did a quick test against the latest Chrome, Node.js, and Edge and none of them had WeakSet.prototype.clear or WeakMap.prototype.clear defined as far as I could tell.

  4. mhegazy commented on Jan 19, 2016

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Jan 19, 2016
    Contributor

    Lucien Greathouse (@LPGhatguy) it needs to be removed. it was part of the spec at an earlier draft but has since been removed.

  5. Mohamed Hegazy (mhegazy)
    added this to the milestone on Jan 19, 2016
  6. Daniel Rosenwasser (DanielRosenwasser)
    added
    Good First IssueWell scoped, documented and has the green light
    on Jan 19, 2016
  7. Daniel Rosenwasser (DanielRosenwasser)
    closed this as completedin #6583on Jan 24, 2016

  8. DanielRosenwasser commented on Jan 24, 2016

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Jan 24, 2016
    Member

    Thanks falsandtru (@falsandtru)!

  9. Daniel Rosenwasser (DanielRosenwasser)
    added
    FixedA PR has been merged for this issue
    on Jan 24, 2016
  10. Mohamed Hegazy (mhegazy)
    modified the milestones: TypeScript 1.8, on Jan 25, 2016
  11. Zhengbo Li (zhengbli)
    added 3 commits that reference this issue on Sep 6, 2016

    Fix microsoft#6500

    4c1010a

    Fix #6500 (#10728)

    21736a1

    Port #10728: Fix #6500

    11e9f50
  12. microsoft
    locked and limited conversation to collaborators on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Breaking ChangeWould introduce errors in existing codeBugA bug in TypeScriptDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issueGood First IssueWell scoped, documented and has the green lightHelp WantedYou can do this

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions