Skip to content

window.open return type #6418

Closed
microsoft/TypeScript-DOM-lib-generator
#46
Closed
window.open return type#6418
microsoft/TypeScript-DOM-lib-generator
#46
Labels
Breaking ChangeWould introduce errors in existing codeBugA bug in TypeScriptDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issueHelp WantedYou can do this
Milestone
TypeScript 1.8

Description

@JirkaDellOro
Jirka Dell'Oro-Friedl (JirkaDellOro)
opened on Jan 9, 2016

In the lib.d.ts I found, that the return type of the window.open method is declared as any. Shouldn't it be Window?

Activity

  1. Ryan Cavanaugh (RyanCavanaugh)
    added
    BugA bug in TypeScript
    Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScript
    on Jan 11, 2016

  2. RyanCavanaugh commented on Jan 11, 2016

    @RyanCavanaugh
    Ryan Cavanaugh (RyanCavanaugh)
    on Jan 11, 2016
    Member

    Zhengbo Li (@zhengbli) can you confirm?

  3. Ryan Cavanaugh (RyanCavanaugh)
    assigned
    Zhengbo Li (zhengbli)
    on Jan 11, 2016
  4. Daniel Rosenwasser (DanielRosenwasser)
    added this to the TypeScript 1.8 milestone on Jan 11, 2016

  5. zhengbli commented on Jan 11, 2016

    @zhengbli
    Zhengbo Li (zhengbli)
    on Jan 11, 2016

    The reason it is any now is that technically it returns a WindowProxy object, for which the XML spec does have a definition.
    However according to the W3 spec:

    As mentioned earlier, each browsing context has a WindowProxy object. This object is unusual in that it must proxy all operations to the Window object of the browsing context's active document. It is thus indistinguishable from that Window object in every way, except that it is not equal to it.

    So it might be ok to use window instead in lib.d.ts

  6. Mohamed Hegazy (mhegazy)
    added
    Breaking ChangeWould introduce errors in existing code
    Help WantedYou can do this
    on Jan 11, 2016
  7. Mohamed Hegazy (mhegazy)
    modified the milestones: , TypeScript 1.8 on Jan 11, 2016
  8. Zhengbo Li (zhengbli)
    closed this as completedin TypeScript-DOM-lib-generator#46on Jan 18, 2016
  9. Zhengbo Li (zhengbli)
    added
    Fixed in TSJS repo
    on Jan 18, 2016
  10. Mohamed Hegazy (mhegazy)
    modified the milestones: TypeScript 1.8, on Jan 19, 2016
  11. Zhengbo Li (zhengbli)
    added
    FixedA PR has been merged for this issue
    and removed
    Fixed in TSJS repo
    on Jan 20, 2016
  12. microsoft
    locked and limited conversation to collaborators on Jun 19, 2018
  13. TypeScript Bot (typescript-bot)
    unassigned
    Zhengbo Li (zhengbli)
    on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Breaking ChangeWould introduce errors in existing codeBugA bug in TypeScriptDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issueHelp WantedYou can do this

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions