Repository navigation
lib.d.ts HTMLTableElement, HTMLTableSectionElement, and HTMLTableRowElement #3583
Description
A couple of html table related methods in lib.d.ts return HTMLElement, but they could return a more precise type:
- HTMLTableElement.insertRow should return HTMLTableRowElement instead of HTMLElement
- HTMLTableElement.createTHead should return HTMLTableSectionElement instead of HTMLElement
- HTMLTableElement.createTBody should return HTMLTableSectionElement instead of HTMLElement
- HTMLTableElement.createTFoot should return HTMLTableSectionElement instead of HTMLElement
- HTMLTableElement.createCaption should return HTMLTableCaptionElement instead of HTMLElement
- HTMLTableSectionElement.insertRow should return HTMLTableRowElement instead of HTMLElement
- HTMLTableRowElement.insertCell should return HTMLTableCellElement instead of HTMLElement
Activity
djarekg commentedon Jun 24, 2015
How about also HTMLTableElement cells and rows property return a new generic type HTMLCollectionOf where cells is HTMLCollectionOf and rows is HTMLCollectionOf. And the HTMLTableRowElement cells property would be HTMLCollectionOf.
matthewrwilton commentedon Sep 30, 2015
Seems like this didn't make v1.6. Is it possible to get a milestone update?
mhegazy commentedon Sep 30, 2015
Zhengbo Li (@zhengbli) is working on releasing the script that generates the typings file. it should come out shortly, and with that we should be able to take PRs for features like this one. putting it on Zhengbo Li (@zhengbli) for now.
3 remaining items
zhengbli commentedon Nov 11, 2015
The
HTMLTableElement.rowsis not onlyHTMLTableRowElement, it also contains headers and other types spec, the same goes forHTMLTableRowElement.cells.zhengbli commentedon Nov 30, 2015
I have a PR fixing this at microsoft/TypeScript-DOM-lib-generator#24
If you want to take a look Mohamed Hegazy (@mhegazy) @sockfish